Skip to content

Build system, CI and fixes - #141

Open
xl0 wants to merge 10 commits into
Qix-:masterfrom
xl0:build
Open

Build system, CI and fixes#141
xl0 wants to merge 10 commits into
Qix-:masterfrom
xl0:build

Conversation

@xl0

@xl0 xl0 commented Oct 22, 2025

Copy link
Copy Markdown
Contributor
  • Update the build system
  • CI tests on mac and win, reduced the number of versions we test
  • Fix unit test test, chaining just works
  • Publish workflow:
    • Push a tag - publishes to pypy
    • If tag has -test in it, publishes to test.pypi
  • Fix AST to work with all python version, highlight named constants (True, False, None) on legacy.
  • Remove leftover python 2 checks.

@xl0

xl0 commented Oct 22, 2025

Copy link
Copy Markdown
Contributor Author

Min version is 3.7, which is the last version with significant downloads on pypi.

@xl0

xl0 commented Oct 22, 2025

Copy link
Copy Markdown
Contributor Author

Also, pip install -e does not install the hook. I never figured out how to do it for lovely-tensors, and I think the issues lies with editable installs being hooks themselves, and while it might be possible to figure it out, I don't think it's worth the time. I don't think this ever worked, at least not with modern python.

Comment thread .github/workflows/push.yml Outdated
@Qix-

Qix- commented Oct 22, 2025

Copy link
Copy Markdown
Owner

Wow, this is amazing. I learned a lot just reading through this; thank you so much for taking the time.

I'm pretty dead for the evening today, let me get to this tomorrow as I'll need to set up the trusted publishing stuff as well and make sure everything works.

Thank you again!

@xl0

xl0 commented Oct 27, 2025

Copy link
Copy Markdown
Contributor Author

@Qix- Hey, just checking in, all good? Let me know if something does not work or does not make sense.

@xl0

xl0 commented Nov 16, 2025

Copy link
Copy Markdown
Contributor Author

@Qix- 👋 👋

@Qix-

Qix- commented Nov 17, 2025

Copy link
Copy Markdown
Owner

Haven't forgotten about this (It's been sitting in my inbox), I just haven't had time the last few weeks to sit down and figure it out. Sorry about that <3 Will do it soon.

@xl0

xl0 commented Mar 11, 2026

Copy link
Copy Markdown
Contributor Author

@Qix- Pretty please merge and release. The current version does not work out of the box, so I end up pip-installing form my branch.

@xl0

xl0 commented May 22, 2026

Copy link
Copy Markdown
Contributor Author

@Qix- 👋 👋

@xl0

xl0 commented May 30, 2026

Copy link
Copy Markdown
Contributor Author

@Qix- Any chance you'd like me to become the maintainer of this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants