security: harden spawn callbacks and workflows - #37
Draft
pushkart2 wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
pull_request_targetlint trigger withpull_requestWhy
The spawn callbacks performed a database query on every invocation and dereferenced player/query/JSON data without validation. Separately, the lint workflow checked out contributor-controlled code in a privileged
pull_request_targetcontext; CodeQL flags that path as high severity. Mutable action tags and implicit token permissions increased the workflow supply-chain exposure.Impact
Normal spawn setup still makes one request to each callback; duplicate requests in the same second fail closed. Contributor PRs keep Lua lint coverage without privileged code execution, and trusted runs keep the standalone lint report.
Validation
actionlint1.7.12git diff --check