Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 Claude Code Review
Bug:
usernameis typedstr | Noneand defaults toNone.Hive(username=None)is allowed (session/__init__.py:38), andstart_sessionpassesconfig.get("username", self.config.username)here (discovery.py:192). If the username isNone,None.strip()raisesAttributeError, sostart_session()crashes. The same happens ifconfig={"username": None}. Before this PR, the==comparison handledNone.Suggested fix:
Also note that
hive_auth_async.py:82andhive_auth.py:114still use the exact== "use@file.com"check, so the normalisation is inconsistent. No test was added for the new behaviour (mixed case, whitespace,None).