Upstramming main into dev - #1522
Merged
Merged
Conversation
…function Added a deprecation warning for the gen_sentence function in thai2fit.py.
Added a deprecation warning for WangChanGLM class.
Added deprecation warning for ChatBotModel.
Removed unused imports from fastai and updated type hints.
Add warn deprecation pythainlp.generate.thai2fit, pythainlp.generate.wangchanglm, and pythainlp.chat
Add warn deprecation pythainlp.generate.thai2fit, pythainlp.generate.wangchanglm, and pythainlp.chat
## Deprecated - Add warn deprecation `pythainlp.generate.thai2fit`, `pythainlp.generate.wangchanglm`, and `pythainlp.chat`. (PR #1519) ### Fixed - `pythainlp.transliterate.romanize` with the `thai2rom` and `thai2rom_onnx` engines: greedy decoding could get stuck in a cycle and run to the hard 100-character length cap, returning strings like `krungtheppaaaa...aaaa` for inputs such as `กรุงเทพฯ`, `ฯลฯ`, or long Pali/Sanskrit-derived compounds. Decoding now stops as soon as a short output cycle repeats 3 times in a row. (issue #1403, PR #1500) - `pythainlp.transliterate.thaig2p.transliterate`: found while fixing issue #1403, the same greedy-decoding `Seq2Seq` loop as `thai2rom` could get stuck in a repetition cycle and run to the hard 100-character cap for the same class of inputs (e.g. `สตรีเศรษฐบุตรบำเพ็ญ`, and long unsegmented multi-word phrases). Fixed with the same cycle-detection guard used for `thai2rom`. (PR #1501) - `pythainlp.util.text_to_num`: handle Thai zero ("ศูนย์") in floating-point (PR #1503)
PyThaiNLP v5.3.8 Released!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstramming main into dev