Skip to content

[WIP] Add FastThaiG2P - #1499

Open
wannaphong wants to merge 1 commit into
devfrom
add-fastthaig2p
Open

wannaphong wants to merge 1 commit into
devfrom
add-fastthaig2p

Conversation

@wannaphong

Copy link
Copy Markdown
Member

What do these changes do

Add FastThaiG2P to PyThaiNLP

GitHub: https://github.com/cstorm125/FastThaiG2P

report: https://arxiv.org/abs/2608.12814

Fixes #1484

Your checklist for this pull request

  • Passed code styles and structures
  • Passed code linting checks and unit test

@sonarqubecloud

Copy link
Copy Markdown

@wannaphong

wannaphong commented Sep 11, 2026

Copy link
Copy Markdown
Member Author

@bact I am not sure about SPDX head in pythainlp/transliterate/fastthaig2p.py.

# SPDX-FileCopyrightText: 2016-2026 PyThaiNLP Project
# SPDX-FileType: SOURCE
# SPDX-License-Identifier: Apache-2.0

or

# SPDX-FileCopyrightText: 2026 Charin Polpanumas and Amazon Web Services
# SPDX-FileType: SOURCE
# SPDX-License-Identifier: Apache-2.0

or not both?

@bact

bact commented Sep 13, 2026

Copy link
Copy Markdown
Member

The format is correct.

For the copyright text, depends on what you like to have. It is also possible to have multiple lines of copyright text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants