Repository navigation
feat: show other providers' battery devices in the widgets - #27
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Lets both widgets show devices that other providers publish to Macro Deck's battery catalog (SDK beta.17,
IIntegrationContext.Batteries), such as the phones from the built-in ADB integration, next to this plugin's own devices.device - provider. This plugin's own catalog entries are filtered out by the id it published.provider:id). The colon keeps those ids from ever clashing with our own device ids.battery_<id>_*variables, no events and no trend.ExternalBatteryDevices.RowKey). A test opens a real widget session to cover this.Changedhandler on every re-initialization, and widget sessions stay open across that. So the integration re-subscribes inInitializeAsyncand raises its ownBatteryCatalogChanged, which the sessions listen to.NotChargingreads as Full at 100 % and Unknown below, matching our macOS and Linux sources.sourceIdsdescription in the widget data schema are updated. There is one new string,Widgets.Config.Devices.External.Checklist
dotnet buildanddotnet testpass locally (0 warnings, 316 tests).Device/hardware tested against (if applicable)
Not a device backend.