Fix B104 false negative for empty-string wildcard bind#1396
Open
9iang22 wants to merge 1 commit intoPyCQA:mainfrom
Open
Fix B104 false negative for empty-string wildcard bind#13969iang22 wants to merge 1 commit intoPyCQA:mainfrom
9iang22 wants to merge 1 commit intoPyCQA:mainfrom
Conversation
9iang22
requested review from
ericwb,
lukehinds and
sigmavirus24
as code owners
ericwb
requested changes
Apr 20, 2026
Member
ericwb
left a comment
ericwb
left a comment
There was a problem hiding this comment.
This results in too many false positives.
| @test.test_id("B104") | ||
| def hardcoded_bind_all_interfaces(context): | ||
| if context.string_val == "0.0.0.0": # nosec: B104 | ||
| if context.string_val in ("0.0.0.0", ""): # nosec: B104 |
Member
There was a problem hiding this comment.
This results in an excessive number of false positives. This effectively matches a str literal of the empty string (""). So it would match tons of lines in a code base.
For example, even the most basic snippet of code:
test_str = ""
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
B104detection to treat""as a wildcard bind host in addition to"0.0.0.0".socket.bind(("", port)).Validation
python -m pytest tests/functional/test_functional.py -k binding.Resolved: #1395