Fix B202: detect unsafe tarfile.extract usage#1393
Open
9iang22 wants to merge 1 commit intoPyCQA:mainfrom
Open
Fix B202: detect unsafe tarfile.extract usage#13939iang22 wants to merge 1 commit intoPyCQA:mainfrom
9iang22 wants to merge 1 commit intoPyCQA:mainfrom
Conversation
9iang22
requested review from
ericwb,
lukehinds and
sigmavirus24
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix B202 gap for tarfile.extract() calls
B202 currently flags unsafe tar extraction through extractall(), but it does not catch equivalent member-by-member extraction done with tarfile.extract(). This leaves a false-negative path for the CWE-22 path traversal when archive members are not validated.
This change closes that coverage gap, so B202 reports both extraction APIs consistently under the same safety model.
It also updates the functional example and expected counts so that test coverage reflects the added detection path.
Resolves: #1392