Skip to content

fix: allow more flexibility in choosing models used for PII removal - #135

Merged
Prajna1999 merged 9 commits into
ProjectTech4DevAI:mainfrom
dennyabrain:feat/pii_improvements
Aug 26, 2026
Merged

fix: allow more flexibility in choosing models used for PII removal#135
Prajna1999 merged 9 commits into
ProjectTech4DevAI:mainfrom
dennyabrain:feat/pii_improvements

Conversation

@dennyabrain

@dennyabrain dennyabrain commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

This PR allows configuring the model used for by recognizer within Presidio. This removed the issue with false positives in hinglish text messages.

We have added 2 new parameters to the config for PII validator - nlp_engine_type and model_name. A sample initialization of pii validator now looks like this -

pii_validator = PIIRemover(
    entity_types=[
        "EMAIL_ADDRESS",
        "PHONE_NUMBER",
        "IN_AADHAAR",
        "PERSON",
        "IN_PAN",
        "LOCATION",
        "IN_VOTER",
        "IN_PASSPORT",
        "IN_VEHICLE_REGISTRATION",
        "URL",
    ],
    nlp_engine_type="transformers",
    model_name="dslim/bert-base-NER-uncased"
)

Since it helps to pre-download the models used by the validator, we are doing so in the Dockerfile. For now I have downloaded both models - one used by nlp_engine_type="spacy" and nlp_engine_type="transformers", we can probably choose one or a few that suits us in production. The changes to Dockerfile are indicative of what sort of changes are needed to support this PR and can use further scrutiny and discussion with the larger team.

Checklist

Before submitting a pull request, please ensure that you mark these task.

  • Ran fastapi run --reload app/main.py or docker compose up in the repository root and test.
  • If you've fixed a bug or added code that is tested and has test cases.

Notes

Please add here if any other information is required for the reviewer.

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • ready-for-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 665fbe81-e542-4a5f-a1f4-bf91485f15d8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dennyabrain
dennyabrain marked this pull request as draft July 7, 2026 16:16
@Prajna1999

Copy link
Copy Markdown
Contributor

@dennyabrain is this PR ready for review?

@dennyabrain

Copy link
Copy Markdown
Collaborator Author

@Prajna1999 You can start reviewing now.

@Prajna1999
Prajna1999 marked this pull request as ready for review August 26, 2026 05:30
@Prajna1999
Prajna1999 self-requested a review August 26, 2026 05:30

@Prajna1999 Prajna1999 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge after fixing test cases

@Prajna1999
Prajna1999 merged commit bd1a82d into ProjectTech4DevAI:main Aug 26, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants