Repository navigation
asapv1: DDSketch kinds 05 01 / 05 81; 05 00 / 05 80 retired - #106
Merged
Merged
Conversation
The ASAPv1 registry follows asap_sketchlib: DDSketch's state is now kind
05 01 (bucket stores and zero count, no sum / min / max) and its delta
05 81. The retired 05 00 ("DDSketch with scalars") and its delta 05 80
stay registered with a payload, since decoders still accept them.
Also registers 1e 00 (CMSSpaceSaving) and 1f 00 (CSSpaceSaving), whose
fixtures the golden submodule already carries, and points asapv1_golden
at the commit with the ddsketch_buckets_* fixtures (08440a1).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of ProjectASAP/asap_sketchlib#250. Mirrors the registry change in ProjectASAP/asap_sketchlib#252. Base:
main.Why
asap_sketchlibmoves DDSketch to kind05 01(bucket stores and zero count, with no sum / min / max) and its delta to05 81. The retired05 00/05 80still decode. Go'smainhas no DDSketch ASAPv1 codec (that is #90), but its registry and golden check have to know the new ids. OtherwiseTestEveryFixtureIsWellFormedfails once the golden submodule carries theddsketch_buckets_*fixtures.What
KindDDSketch=05 01andKindDDSketchDelta=05 81(they were05 00/05 80).KindDDSketchWithScalars(05 00, "DDSketch with scalars") andKindDDSketchWithScalarsDelta(05 80), both registered with a payload because decoders accept them.KindCMSSpaceSaving(1e 00) andKindCSSpaceSaving(1f 00), Rust's CountMinSketchWithSpaceSaving and CountSketchWithSpaceSaving. The golden submodule already carries their fixtures, and leaving them out fails the same test.asapv1_goldenmoves fromcf56579to08440a1(ddsketch: fixtures for the buckets-only kinds 05 01 / 05 81 sketchlib-golden-bytes#4). That span includes the delta, admission and seed-derivation fixtures.kind.godiff isgofmtrealignment.Verification
TestEveryFixtureIsWellFormedfailed on05 01,05 81,1e 00and1f 00.go test ./wire/...: pass (TestRegistry,TestEveryFixtureIsWellFormed).go test ./sketches/DDSketch/... ./sketch_framework/...: pass.go vet ./wire/...: clean.Merge order
mainregistry PR (branchddsketch/kind-0501).asapv1-only/ddsketch) rebased onto Gomain, takingmain'swire/asapv1/kind.go(theregistry/kindEntryshape). That brings in05 01/05 81/05 00/05 80and the delta kinds.ddsketch/buckets-0501) restacked on the rebased feat(ddsketch)!: ASAPv1 codec with signed values; drop the protobuf, msgpack, delta and gob formats #90, with itskind.go/kind_test.gohunks dropped.Limitations
KindDDSketch*onmain. The legacy msgpack / gob DDSketch formats and the in-memorysum/min/maxthere are untouched; feat(ddsketch)!: ASAPv1 codec with signed values; drop the protobuf, msgpack, delta and gob formats #90 replaces them.🤖 Generated with Claude Code