Repository navigation
sketch-bench: asap_sketchlib a05b35c, the library's memory_bytes, and the rows table moved in from aqpbm-cli - #234
Merged
Merged
Conversation
… the rows table moved in from aqpbm-cli - The workspace pins asap_sketchlib to git rev a05b35c (0.4.0 plus main through #262); aqpbm-planeval takes the same workspace dependency, so the lockfile carries one copy of ours instead of the crates.io 0.3.0 one. - The wrappers follow the 0.4.0 names: update for insert, CountMinSketch, CountSketch, CountMinSketchWithHeap, CountSketchWithHeap, HeapEntry, Kll, DdSketch, Ertl, HyperLogLogHip, HllRegistersP*, UnivMon::new, layer_heaps, estimate_*, and the HydraCounter variants. - Every sketchlib row reports the library's own memory_bytes. The formulas that reproduced 0.3 internals (aqpbm-core's heap_footprint, the KLL slot count, the Hydra grid overhead) and the tests that asserted them are gone. The oxide rows keep their formulas. - aqpbm-cli/src/rows moves to sketch-bench/src/rows, so aqpbm-cli names no asap_sketchlib type and calls sketch_bench::rows::measurements. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ntions, and show HLL memory as the library reports it Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependency. The workspace pins
asap_sketchlibto git reva05b35c, which is 0.4.0 plus main through #262.aqpbm-planevaltakes the same workspace dependency, soCargo.lockholds two copies, ours and ASAPPlanner's own21b6357, instead of three. To move to another sketchlib commit, editrevin the rootCargo.toml.0.4.0 names.
update(UnivMon's isupdate_weighted).CountMinSketch,CountSketch,CountMinSketchWithHeap,CountSketchWithHeap,HeapEntry,Kll(with_k,Cdf::value_at),DdSketch,Ertl,HyperLogLogHip,HllRegistersP*.new,layer_heaps,estimate_*.HydraCountervariants follow the new names.Memory. Every sketchlib row now reports the library's own
memory_bytes(). The parallel-insert rows reportworkers ×the library'stheoretical_memory_bytesfor the shape each worker uses. Three hand-written formulas copied 0.3's internals and are deleted, along with the tests that asserted them:aqpbm-core'sheap_footprint(the 0.3HHHeaplayout)The DDSketch formula and the oxide rows' formulas stay.
rows/moves from aqpbm-cli to sketch-bench.aqpbm-cli/src/rowsis nowsketch-bench/src/rows, and the CLI callssketch_bench::rows::measurements. aqpbm-cli's source no longer names anyasap_sketchlibtype; it still links the library through sketch-bench. The re-export of sketchlib types inwrappers/mod.rsis gone.Numbers that change
Earlier results should be re-baselined rather than compared directly.
Docs
docs/rqe_optimizer_hydra.mdpoints atsketch-bench/src/rows/mod.rs, drops the 0.3.0 mentions, and states the footprint asHydra::memory_bytes.docs/e2e_planning_flow.mddrops the 0.3.0 mention.README.mdshows thehllsample'smemory_bytesas the library reports it (16400 atlg_k = 14).The results READMEs under
rqe-optimizer/results/still say 0.3.0, because those runs were measured on it.Test plan
cargo build --releasecargo test --workspace --no-fail-fast: all passcargo fmt --all --checkapproxbench sketchbench --variant cms-heap-topk-fastpath-vector2d --library lib --config 'rows=5 cols=2048 heap=128'on 1M Zipf(1.1) keys: insert 30.3 M items/s,memory_bytes58,904 (40,960 bytes of counters plus the struct and a 128-entry heap)🤖 Generated with Claude Code