Skip to content

test(devtools): plan snapshots for 33 small single-purpose workloads (#1278) - #1284

Open
milindsrivastava1997 wants to merge 1 commit into
refactor/1207-toolsfrom
test/1278-snapshot-workloads
Open

milindsrivastava1997 wants to merge 1 commit into
refactor/1207-toolsfrom
test/1278-snapshot-workloads

Conversation

@milindsrivastava1997

Copy link
Copy Markdown
Collaborator

Summary

Adds 33 small, single-purpose workloads to sketch_plan_snapshots, each pinning one memo behavior through its selected plan. Closes #1278. Stacked on #1239 (refactor/1207-tools).

Review guide

  • crates/devtools/tests/sketch_plan_snapshots/manifest.json: the 33 new entries. Each covers says what the workload pins and names the issue when the plan reflects a known gap.
  • crates/devtools/tests/sketch_plan_snapshots.rs: one header paragraph.
  • workloads/*.json and <id>.json snapshots are generated or copied; skim them.
area ids
rollup across label sets rollup-quantile-nested-labels, rollup-quantile-disjoint-labels, rollup-sum-chain, stddev-nested-labels, avg-nested-labels, sql-rollup-quantile-same-window, sql-rollup-quantile-different-windows
top-k topk-5-and-10, topk-by-job-and-global, topk-5-and-10-accuracy, topk-rate-counter, topk-sum-count-over-time, topk-sum-count-over-time-accuracy
chains quantile-over-time-no-phase, quantile-over-time-phase-0, chains-10m-5m-3m-3m, chains-10m-5m-3m-10s, chains-10m-5m-3m-10s-mvp, sum-over-time-two-intervals, quantile-phase-0-and-30s, quantile-7m-every-5m
over-time aggregates sum-avg-over-time-5m, sum-5m-avg-10m-over-time, mixed-quantiles
sketch choice distinct-over-time-1pct, distinct-over-time-5pct, entropy-over-time, quantile-two-targets, distinct-two-forms, entropy-and-distinct, quantile-exact, sign-unknown, sign-non-negative

All are on data (10k gauge series, 15 s samples), mostly every 1m at phase 0, under raw_retained (one under mvp). The two SQL workloads use workloads/sql-table-data.tables.json.

Behavior: before → after

rollup-quantile-nested-labels (quantile by (job) (0.9, data) + quantile by (job, host) (0.9, data)):

Interfaces

None.

Algorithm changes

None.

Decisions and open questions

Verification

  • UPDATE_SNAPSHOTS=1 cargo test --release -p asap-devtools --test corpus_snapshots -- --ignored sketch_plans_match_snapshots, then the same without UPDATE_SNAPSHOTS: passes (43 workloads, ~5.6 s).
  • Snapshot changes: none of the 10 existing snapshots changed. The 33 new ones are added; they record the plans described in each covers.
  • Reviewer confirms the recorded plans are the intended baseline: (for a person to fill in)

Follow-ups

🤖 Generated with Claude Code

https://claude.ai/code/session_014qhwq4GZoWwtfFWWr9CKkr

…kloads (#1278)

Each workload pins one memo behavior through its selected plan: rollup
across label sets, top-k reuse, chain widths and sharing, avg as
Sum / Count, and which sketches an accuracy target or a declared value
sign admits. The snapshots record current behavior, including the known
gaps (#1260, #1270, #1281, #1282) named in each `covers`, so their
fixes show up as snapshot diffs. Existing snapshots are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014qhwq4GZoWwtfFWWr9CKkr
@milindsrivastava1997 milindsrivastava1997 changed the title test(devtools): sketch plan snapshots for 33 small single-purpose workloads (#1278) test(devtools): plan snapshots for 33 small single-purpose workloads (#1278) Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant