Repository navigation
test(devtools): plan snapshots for 33 small single-purpose workloads (#1278) - #1284
Open
milindsrivastava1997 wants to merge 1 commit into
Open
milindsrivastava1997 wants to merge 1 commit into
milindsrivastava1997 wants to merge 1 commit into
Conversation
…kloads (#1278) Each workload pins one memo behavior through its selected plan: rollup across label sets, top-k reuse, chain widths and sharing, avg as Sum / Count, and which sketches an accuracy target or a declared value sign admits. The snapshots record current behavior, including the known gaps (#1260, #1270, #1281, #1282) named in each `covers`, so their fixes show up as snapshot diffs. Existing snapshots are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014qhwq4GZoWwtfFWWr9CKkr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 33 small, single-purpose workloads to
sketch_plan_snapshots, each pinning one memo behavior through its selected plan. Closes #1278. Stacked on #1239 (refactor/1207-tools).Review guide
crates/devtools/tests/sketch_plan_snapshots/manifest.json: the 33 new entries. Eachcoverssays what the workload pins and names the issue when the plan reflects a known gap.crates/devtools/tests/sketch_plan_snapshots.rs: one header paragraph.workloads/*.jsonand<id>.jsonsnapshots are generated or copied; skim them.rollup-quantile-nested-labels,rollup-quantile-disjoint-labels,rollup-sum-chain,stddev-nested-labels,avg-nested-labels,sql-rollup-quantile-same-window,sql-rollup-quantile-different-windowstopk-5-and-10,topk-by-job-and-global,topk-5-and-10-accuracy,topk-rate-counter,topk-sum-count-over-time,topk-sum-count-over-time-accuracyquantile-over-time-no-phase,quantile-over-time-phase-0,chains-10m-5m-3m-3m,chains-10m-5m-3m-10s,chains-10m-5m-3m-10s-mvp,sum-over-time-two-intervals,quantile-phase-0-and-30s,quantile-7m-every-5msum-avg-over-time-5m,sum-5m-avg-10m-over-time,mixed-quantilesdistinct-over-time-1pct,distinct-over-time-5pct,entropy-over-time,quantile-two-targets,distinct-two-forms,entropy-and-distinct,quantile-exact,sign-unknown,sign-non-negativeAll are on
data(10k gauge series, 15 s samples), mostly every 1m at phase 0, underraw_retained(one undermvp). The two SQL workloads useworkloads/sql-table-data.tables.json.Behavior: before → after
rollup-quantile-nested-labels(quantile by (job) (0.9, data)+quantile by (job, host) (0.9, data)):asap_plannerby hand.SummaryMergefrom the(job, host)KLL.Interfaces
None.
Algorithm changes
None.
Decisions and open questions
Verification
UPDATE_SNAPSHOTS=1 cargo test --release -p asap-devtools --test corpus_snapshots -- --ignored sketch_plans_match_snapshots, then the same withoutUPDATE_SNAPSHOTS: passes (43 workloads, ~5.6 s).covers.Follow-ups
🤖 Generated with Claude Code
https://claude.ai/code/session_014qhwq4GZoWwtfFWWr9CKkr