Repository navigation
cuda: warp-per-row PTQ1_0 mat-vec for MUL_MAT_ID when K <= 4096 - #415
Merged
Merged
Conversation
The generic loop strides the 128-weight blocks over all threads of the CTA, so at K <= 4096 (<= 32 blocks per row) only the first warp loads. Give each warp its own row and let the lanes stride the blocks, with the same per-row accumulation order and epilogue, so outputs are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
CTA now owns one row, and its lanes stride that row's 128-weight blocks on the planar layout.
Why
the first warp loads anything, so MoE expert mat-vecs at these shapes ran at about 0.5 TB/s on H200.
How
bit-identical to the current path.
Testing
depending on how much of the token time the expert mat-vecs take. No change on dense PTQ1_0 models.