Repository navigation
cuda: tall one-column mat-vec for Q8_0/Q4_0/Q2_0/Q4_K/Q6_K on Hopper, and allow folded Gemma 4 weights - #413
Merged
Merged
Conversation
…=4096 on Hopper (GGML_CUDA_MMVQ_TALL_EXT) Extend the 8-rows-per-CTA one-column mat-vec geometry, previously used for PQ2_0 only, to Q8_0, Q4_0, Q2_0, Q4_K and Q6_K when the matrix has at least 4096 rows (a multiple of 8) on Hopper. The K partition and reduction order per row are unchanged, so every output row is bit-identical to the default geometry. GGML_CUDA_MMVQ_TALL_EXT=0 restores the PQ2_0-only behavior (default: enabled).
Every folded Gemma 4 weight (attention q/k/v/o, shared FFN, routed experts) goes through build_lora_mm / build_lora_mm_id, which apply the activation transform.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
GGML_CUDA_MMVQ_TALL_EXT=0restores the old PQ2_0-only behavior.Why
How
Testing (H200)