Repository navigation
tests: MUL_MAT_ID cases for the one-column mat-vec store (small K, several expert rows per block) - #295
Open
professorpalmer wants to merge 1 commit into
Conversation
Collaborator
|
Thanks. This still doesn't build on prism: #258 added its own nrows_dst bound in mul_mat_vec_q (ids ? stride_channel_dst : stride_col_dst), so the new declaration at mmvq.cu:620 collides with it. That bound already covers the one-column case: I applied only your test hunk to current prism and all 50 new MUL_MAT_ID cases pass (1085/1085). Could you drop the kernel change and keep the test? Then it's ready to merge as a regression test. |
…veral expert rows per block) The kernel bound from the first version of this PR is dropped: prism PrismML-Eng#258 already bounds the store (nrows_dst = ids ? stride_channel_dst : stride_col_dst), and these cases pass with it. They stay as a regression test.
professorpalmer
force-pushed
the
cuda-mmvq-mmid-row-bound
branch
from
October 27, 2026 20:02
4cdb698 to
ed56a5c
Compare
Author
|
Thank you. Done in RTX 4070 (sm_89), CUDA 13: |
professorpalmer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression test only. The kernel bound from the first version is dropped: prism #258 already bounds the one-column MUL_MAT_ID store (
nrows_dst = ids ? stride_channel_dst : stride_col_dst). These cases pass with it:test-backend-ops -o MUL_MAT_ID1085/1085 on an RTX 4070 (prism c96baf4).