Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #18 +/- ##
===========================================
+ Coverage 99.30% 99.34% +0.03%
===========================================
Files 11 11
Lines 1159 1230 +71
Branches 77 80 +3
===========================================
+ Hits 1151 1222 +71
Misses 4 4
Partials 4 4 🚀 New features to boost your workflow:
|
laurejt
marked this pull request as ready for review
September 29, 2026 20:53
rlskoeser
reviewed
Oct 1, 2026
rlskoeser
left a comment
There was a problem hiding this comment.
Reviewed the readme and provided some suggestions/feedback.
|
|
||
| ```sh | ||
| pip install git+https://github.com/Princeton-CDH/spanerr.git#egg=spanerr | ||
| ``` |
There was a problem hiding this comment.
Are you planning to publish on pypi? I would recommend doing that (would be nice to claim the package name). The easiest way is to use github actions workflow and pypi trusted publishing.
Contributor
Author
There was a problem hiding this comment.
Yes, that's my plan. Perhaps we can talk tomorrow about making an official submission? I plan on adding a GitHub Action once we get the initial release on pypi (but I could be misremembering the best workflow here).
Co-authored-by: Rebecca Sutton Koeser <rlskoeser@users.noreply.github.com>
Also simplify aligner constructor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue(s): resolves #15
Changes in this PR
spanerr-metricsproject script topyproject.toml(runscompute_metrics.py)--binaryoption tocompute_metrics.pyto for binarizing inputs--save-intermediateoption tocompute_metrics.pyfor saving intermediate (document-level) resultsNotes
--binaryto--binarize?Notes for Testing
Case 1. Binarize labels
Note that these are the same strategy choices used in #14's test cases.
Command:
Final Output
Command:
Final Output
Case 2. Save intermediate results
First, get the intermediate results when computing entity-level aggregated metrics
Command:
Final Output
Intermediate Results (
intmd_ent.csv)Then, get the intermediate results when computing document-level aggregated metrics
Command:
Final Output
Intermediate Results (
intmd_doc.csv)Reviewer Checklist
spanerr-metricsproject script locally (see notes above)