Fix company attribution when the Sponsor company field contains a tem… - #249
Merged
Merged
Conversation
…plate placeholder
jolelievre
approved these changes
Sep 17, 2026
Contributor
|
That makes sense |
cnavarro-prestashop
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extractCompany()checks the "Sponsor company" field before the employee time frames. Placeholder values such as ~, -, / or the default template text are aliases of "Open Source Community", so PRs from company employees who left the placeholder in are attributed to the community and the employee lookup never runs.For PRs merged in 2025 this misattributes roughly 288 PrestaShop PRs to the community, so the dashboard shows PrestaShop at 56.8% of merged PRs instead of about 69.9%.
This change treats a sponsor value resolving to "Open Source Community" as "no sponsor declared" and falls back to the author's employment time frames. Explicit sponsor companies still take precedence, and unknown sponsor values keep their current behaviour.
Examples
Here are some of @jolelievre 2025 PRs where the Sponsor company field is
~, all of which the dashboard counts as community:In total, 204 of his 2025 PRs have
~, plus one with the untouched template text.The first one, PrestaShop#38169, makes the clearest example for the PR description: it's core work in the main repo by a long-standing PrestaShop employee, and the dashboard attributes it to the community only because of that
~.