feat(company): expose separate github_url field - #241
Merged
Merged
Conversation
The Company DTO already carries html_url (which points to the company website) but no dedicated GitHub URL. This adds an optional github_url so the front can render GitHub + Website as two distinct sidebar entries on the company detail page. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
3 tasks
Progi1984
approved these changes
Jul 28, 2026
github-project-automation
Bot
moved this from Ready for review
to Merged
in PR Dashboard
Progi1984
pushed a commit
to PrestaShop/TopContributors
that referenced
this pull request
Jul 28, 2026
Company entries carry the company's **website** in html_url, not a GitHub URL, so labeling it "GitHub" was misleading. Render two distinct sidebar entries: an optional GitHub link driven by the new github_url field, and a Website link keyed off html_url (with the same icon the contributor sidebar uses). Consumes the github_url field added to topcompanies_prs.json in PrestaShop/traces#241. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github_urlfield to the Company DTO and its serialized output intopcompanies_prs.json.var/data/companies.jsoninGenerateTopCompaniesCommand.Motivation
html_urlon a company entry points to the company's website, not to GitHub. The front (TopContributors) currently renders it under a "GitHub" label on the company detail page, which is misleading. This change lets us surface both links cleanly (Website + GitHub) on the front sidebar.The front-side change lives in a companion PR on TopContributors: it renders
github_urlas the GitHub link and keepshtml_urlas the Website link.Test plan
topcompanies_prs.jsonand verify PrestaEdit exposes bothhtml_urlandgithub_url.github_urlin the source still generate a valid entry (field isnull).🤖 Generated with Claude Code