Skip to content

Update NARRE with tensorflow 2.21.0#695

Merged
lthoang merged 1 commit into
PreferredAI:masterfrom
lthoang:narre-tf-2.21.0
Jun 4, 2026
Merged

Update NARRE with tensorflow 2.21.0#695
lthoang merged 1 commit into
PreferredAI:masterfrom
lthoang:narre-tf-2.21.0

Conversation

@lthoang
Copy link
Copy Markdown
Member

@lthoang lthoang commented Jun 1, 2026

Description

Related Issues

Checklist:

  • I have added tests.
  • I have updated the documentation accordingly.
  • I have updated README.md (if you are adding a new model).
  • I have updated examples/README.md (if you are adding a new example).
  • I have updated datasets/README.md (if you are adding a new dataset).

@lthoang lthoang force-pushed the narre-tf-2.21.0 branch from 836cd33 to 3cc441d Compare June 1, 2026 07:40
@lthoang lthoang assigned qtuantruong, hieuddo and lthoang and unassigned qtuantruong and hieuddo Jun 1, 2026
@lthoang lthoang requested review from hieuddo and qtuantruong June 1, 2026 07:45
@lthoang lthoang added the models New models, changes to models label Jun 1, 2026
Copy link
Copy Markdown
Member

@qtuantruong qtuantruong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we put a test run result to show that it works?

@hieuddo
Copy link
Copy Markdown
Member

hieuddo commented Jun 4, 2026

I run exp for these two models (NARRE and HRDR). The new code runs fine with new commits. Because HRDR imports some util functions from NARRE, we'd need to merge NARRE first, then HRDR.

Validation

Model RMSE Time (s)
NARRE 0.7228 0.4799
HRDR 0.8614 0.4609

Test

Model RMSE Train (s) Test (s)
NARRE 0.7134 5198.5095 0.4707
HRDR 0.8387 5819.3189 0.4587

@hieuddo hieuddo mentioned this pull request Jun 4, 2026
5 tasks
@lthoang lthoang merged commit 90ec678 into PreferredAI:master Jun 4, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

models New models, changes to models

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants