Fitb literal strings#2936
Open
dbrianwalton wants to merge 3 commits into
Open
Conversation
…acters, including if no <test> is identified for @Correct (using the assembly mode="exercise" pass)
Contributor
Author
|
This file contains example exercises that would not have worked previously that now work. (Claude helped construct the examples.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targeted to address #2460
Description of changes:
@use-answer="yes", it compares with the regex-escaped answer string instead of the answer string itselfxsl:choosefor a case that no answer checker was provided for the correct response so that it used the provided answer. This introduced a second area that would have needed the correction, so instead we used themode="exercise"during assembly-stage to insert a missing<test correct="yes">element so that the same branch of logic is followed whether the author provided the element or not.Although I originally expected I needed exslt for regular expressions, the standard str:replace method using search/replace pairs did the job fine.