Skip to content

fix: Retry adapter flags requests on 502 and 504#460

Merged
marandaneto merged 4 commits into
mainfrom
fix/flags-retry-502-504
Jul 2, 2026
Merged

fix: Retry adapter flags requests on 502 and 504#460
marandaneto merged 4 commits into
mainfrom
fix/flags-retry-502-504

Conversation

@marandaneto

Copy link
Copy Markdown
Member

Summary

  • retry SDK compliance adapter /flags/?v=2 requests on HTTP 502 and 504 using the adapter max_retries setting
  • add focused adapter tests for 502 -> 200 and 504 -> 200 flag evaluation retries

Validation

  • flutter test sdk_compliance_adapter/test/flags_retry_test.dart
  • flutter analyze sdk_compliance_adapter/lib/adapter_server.dart sdk_compliance_adapter/test/flags_retry_test.dart

@greptile-apps

greptile-apps Bot commented Jul 2, 2026

Copy link
Copy Markdown

Reviews (1): Last reviewed commit: "fix: retry adapter flags requests on 502..." | Re-trigger Greptile

Comment thread sdk_compliance_adapter/lib/adapter_server.dart
Comment thread sdk_compliance_adapter/lib/adapter_server.dart
Comment thread sdk_compliance_adapter/test/flags_retry_test.dart
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

posthog-flutter Compliance Report

Date: 2026-07-02 11:51:10 UTC
Duration: 96822ms

✅ All Tests Passed!

45/45 tests passed


Capture Tests

29/29 tests passed

View Details
Test Status Duration
Format Validation.Event Has Required Fields 140ms
Format Validation.Event Has Uuid 118ms
Format Validation.Event Has Lib Properties 115ms
Format Validation.Distinct Id Is String 115ms
Format Validation.Token Is Present 115ms
Format Validation.Custom Properties Preserved 116ms
Format Validation.Event Has Timestamp 116ms
Retry Behavior.Retries On 503 5328ms
Retry Behavior.Does Not Retry On 400 2117ms
Retry Behavior.Does Not Retry On 401 2118ms
Retry Behavior.Respects Retry After Header 8121ms
Retry Behavior.Implements Backoff 15447ms
Retry Behavior.Retries On 500 5225ms
Retry Behavior.Retries On 502 5226ms
Retry Behavior.Retries On 504 5224ms
Retry Behavior.Max Retries Respected 15444ms
Deduplication.Generates Unique Uuids 125ms
Deduplication.Preserves Uuid On Retry 5224ms
Deduplication.Preserves Uuid And Timestamp On Retry 10327ms
Deduplication.Preserves Uuid And Timestamp On Batch Retry 5227ms
Deduplication.No Duplicate Events In Batch 124ms
Deduplication.Different Events Have Different Uuids 115ms
Compression.Sends Gzip When Enabled 116ms
Batch Format.Uses Proper Batch Structure 113ms
Batch Format.Flush With No Events Sends Nothing 108ms
Batch Format.Multiple Events Batched Together 125ms
Error Handling.Does Not Retry On 403 2117ms
Error Handling.Does Not Retry On 413 2118ms
Error Handling.Retries On 408 5225ms

Feature_Flags Tests

16/16 tests passed

View Details
Test Status Duration
Request Payload.Request With Person Properties Device Id 12ms
Request Payload.Flags Request Uses V2 Query Param 10ms
Request Payload.Flags Request Hits Flags Path Not Decide 9ms
Request Payload.Flags Request Omits Authorization Header 9ms
Request Payload.Token In Flags Body Matches Init 9ms
Request Payload.Groups Round Trip 10ms
Request Payload.Groups Default To Empty Object 9ms
Request Payload.Person Properties Distinct Id Auto Populated When Caller Omits It 9ms
Request Payload.Disable Geoip False Propagates As Geoip Disable False 10ms
Request Payload.Disable Geoip Omitted Defaults To False 9ms
Request Payload.Flag Keys To Evaluate Contains Only Requested Key 9ms
Request Lifecycle.No Flags Request On Init Alone 4ms
Request Lifecycle.No Flags Request On Normal Capture 112ms
Request Lifecycle.Two Flag Calls Produce Two Remote Requests 16ms
Request Lifecycle.Mock Response Value Is Returned To Caller 9ms
Side Effect Events.Get Feature Flag Captures Feature Flag Called Event 115ms

@marandaneto marandaneto marked this pull request as ready for review July 2, 2026 11:47
@marandaneto marandaneto requested a review from a team as a code owner July 2, 2026 11:47
@greptile-apps

greptile-apps Bot commented Jul 2, 2026

Copy link
Copy Markdown

Reviews (2): Last reviewed commit: "chore: remove unnecessary changeset" | Re-trigger Greptile

@marandaneto marandaneto merged commit cb77246 into main Jul 2, 2026
27 checks passed
@marandaneto marandaneto deleted the fix/flags-retry-502-504 branch July 2, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants