fix: make Skip setup button actually skip onboarding and setup#2083
Draft
posthog[bot] wants to merge 2 commits intomainfrom
Draft
fix: make Skip setup button actually skip onboarding and setup#2083posthog[bot] wants to merge 2 commits intomainfrom
posthog[bot] wants to merge 2 commits intomainfrom
Conversation
added 2 commits
May 7, 2026 11:49
The button previously called navigateToSetup() (sending the user *to* the setup view) and never marked setup complete or set a directory, so App.tsx fell back to OnboardingFlow because of the !selectedDirectory guard. The guard existed solely to paper over this broken state. Wire the button to a dedicated handleSkip that completes onboarding + setup and routes to task-input, drop the App.tsx guard, and show the button in production as well as dev. TaskInput already handles an empty selectedDirectory via mostRecentRepo. Generated-By: PostHog Code Task-Id: c5a0b893-61f1-40a5-8f84-8d93c1ad2dba
Generated-By: PostHog Code Task-Id: c5a0b893-61f1-40a5-8f84-8d93c1ad2dba
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The dev-only Skip setup button in the onboarding flow didn't actually skip anything — it called
navigateToSetup()(which routes to the setup view) and only flippedhasCompletedOnboarding. App.tsx then bounced the user back to<OnboardingFlow />because of a!selectedDirectoryguard that existed solely to paper over this broken state.Now:
handleSkipcallscompleteOnboarding()+completeSetup()and navigates totask-input(the home view), so the button actually skips both onboarding and the setup view.IS_DEVgate is removed, so the button is available in production too (per the request).!selectedDirectoryguard inApp.tsxis dropped —TaskInputalready handles an emptyselectedDirectoryby auto-populating frommostRecentRepoand exposing a folder picker.handleComplete(used bySignalsStepfor the normal happy-path completion) is unchanged, so the regular flow still routes throughSetupView.Test plan
localStorage.clear()), click Skip setup on the welcome screen → land on the main app's task-input view, no bounce back to onboarding.<SetupView />(unchanged).Created with PostHog Code