Skip to content

fix(inbox): Show real PR status in inbox list rows#2056

Open
Twixes wants to merge 1 commit intomainfrom
posthog-code/fix-inbox-list-pr-badge-status
Open

fix(inbox): Show real PR status in inbox list rows#2056
Twixes wants to merge 1 commit intomainfrom
posthog-code/fix-inbox-list-pr-badge-status

Conversation

@Twixes
Copy link
Copy Markdown
Member

@Twixes Twixes commented May 6, 2026

Summary

In the Inbox, the implementation-PR badge in the list rows looked like an "open" PR even when the PR had been merged or closed, while the same badge in the report detail pane (and in the implementation-task bar) correctly showed merged/closed. So the same PR appeared in two states at once, depending on where you looked.

SlackHog: https://posthog.slack.com/archives/C09SK2PAGKF/p1778066950541599

Changes

Always fetch status of PR.

The inbox list rows passed skipStatusFetch=true to ReportImplementationPrLink
to avoid N parallel `gh` calls, so a merged PR still rendered as "open" green
in the list while the detail pane showed it as merged. Drop the skip path so
the list and detail use the same shared badge with the same fetched state, and
render a neutral gray during the initial load instead of pretending the PR is
open.

Generated-By: PostHog Code
Task-Id: ee5c062f-bf44-4676-9316-f8914a5e0a6d
@Twixes Twixes marked this pull request as ready for review May 6, 2026 13:35
@Twixes Twixes added the stamphog label May 6, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 6, 2026

Reviews (1): Last reviewed commit: "fix(inbox): show real PR status in inbox..." | Re-trigger Greptile

@Twixes Twixes changed the title fix(inbox): show real PR status in inbox list rows fix(inbox): Show real PR status in inbox list rows May 6, 2026
@Twixes Twixes requested review from a team and joshsny May 6, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants