Repository navigation
Link pool devices to the controller by device id - #6
Open
jaltmayerpizzorno wants to merge 1 commit into
Open
jaltmayerpizzorno wants to merge 1 commit into
jaltmayerpizzorno wants to merge 1 commit into
Conversation
device_registry.async_get_or_create's via_device is deprecated and stops working in Home Assistant 2027.8 (current releases log a warning). Register the controller first and pass its device id as via_device_id instead. Same change as in the core branch, where it is tested. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This links the pool devices to the controller device by its device id (
via_device_id) instead of by identifier (via_device).Why
via_deviceis deprecated and stops working in Home Assistant 2027.8. Current releases already log a warning at startup ("callsdevice_registry.async_get_or_createwith a deprecatedvia_deviceparameter").Change
It's a three-line change in
_async_register_devices: the controller hub is already registered first, and its device id is now passed asvia_device_id.It's the same change as in the core branch (PoolsideStan/home-assistant-core#2), which has a test for it. I've also been running it on my own controller: the warning is gone and the devices are still grouped under the controller.
🤖 Generated with Claude Code