Repository navigation
Add TemperatureRiseInformation field constants - #3
Merged
PoolsideStan merged 2 commits intoOct 5, 2026
Merged
PoolsideStan merged 2 commits into
PoolsideStan merged 2 commits into
Conversation
The controller pushes a TemperatureRiseInformation document under each body of water while it heats or cools toward its set point. Its TargetEndDateTime is the predicted completion time the Poolside app shows as "ready in ...". Add the field and key names so consumers can import them like the other status fields. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 1, 2026
Following review of the integration that uses them: drop the unused ActualEndDateTime key (the controller clears the document when a heat-up ends), and add TemperatureState and HeatingEventType with the values the Poolside app requires to show a ready time (SAMPLED, NORMAL). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PoolsideStan
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This adds constants for the
TemperatureRiseInformationbody-of-water status field, next toCURRENT_TEMPERATURE_FIELDandCURRENT_STATE_FIELD:TEMPERATURE_RISE_INFORMATION_FIELD = "TemperatureRiseInformation"TEMPERATURE_RISE_TARGET_END_KEY = "TargetEndDateTime"TEMPERATURE_RISE_STATE_KEY = "TemperatureState",TEMPERATURE_RISE_EVENT_TYPE_KEY = "HeatingEventType"TEMPERATURE_RISE_SAMPLED = "SAMPLED",TEMPERATURE_RISE_NORMAL = "NORMAL"Why
While a body of water heats toward its set point, the controller pushes a JSON document in this field, keyed by the BodyOfWaterUUID.
TargetEndDateTimeis the predicted completion time. The Poolside app shows it as "ready in …" only for a sampled, normal heat-up:TemperatureStateSAMPLEDandHeatingEventTypeNORMAL. These are the names the estimated ready time sensor uses in PoolsideStan/poolside-official-integration#5 and PoolsideStan/home-assistant-core#1. Until now it had to define them itself.The state and event type are plain string constants rather than enums, because only some of their values are known (
SAMPLING/SAMPLED, andNORMAL/MAINTAIN_TEMPERATURE/LEARNING).Observed behavior
These are notes from a live controller and from review, recorded in the comment:
None.TemperatureStateisSAMPLING, and the controller may already fill in a preliminary target.TemperatureStatebecomesSAMPLED, and the controller revisesTargetEndDateTimeevery few minutes.0001-01-01…placeholders.Constants only, so there's no behavior change. Tests and
ruffpass.🤖 Generated with Claude Code