76 cloudy aggregation#83
Conversation
| """combine the cloudFree, depCal, shutterOn and fog masks to obtain valid profiles | ||
|
|
||
| """ | ||
| self.flagValPrf = self.flagCloudFree & (~self.retrievals_highres['depCalMask']) \ |
There was a problem hiding this comment.
Do we also want to consider the saturation flag for the cloud free profile or is this not needed?
There was a problem hiding this comment.
I would shift that to issue #82 and adress it at some later point.
Mostly because is expect some more discussion is needed there.
| if isinstance(flagVal, np.ndarray): | ||
| flagVal = flagVal | ||
| elif flagVal and not isinstance(flagVal, np.ndarray): | ||
| flagVal = self.flagValPrf |
There was a problem hiding this comment.
Would it make sense to save the inputted flagVal when it is an ndarray, ei. data_cube.flagValPrf = flagVal, in case we add some procedure that depends on this variable later in the processing chain?
There was a problem hiding this comment.
Changed as suggested
|
I have an additional test script for the feature introduced by this pull request. Please have a look at it. If you like it we can include it to the official test scripts. test_case_cpv_2024-08-21_exclude_cloudy_profiles_example.ipynb |
Co-authored-by: Håvard Strid Buholdt <143713192+HavardStridBuholdt@users.noreply.github.com>
|
Hi Havard, |
3 participants
After some test and feedback by Håvard it should be now ready to merge.