Add PUF tax detail support and batched fiscal reform scoring#150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--maximum-microsim-batch-sizerelease-builder option and batch tax-expenditure reform microsim materialization by household sliceinterest_deductioninput that actually flows into itemized deductions in this datasetLocal validation
uv run ruff check tools/build_us_fiscal_refresh_release.py packages/populace-build/src/populace/build/us/puf_support.py packages/populace-build/src/populace/build/us/__init__.py packages/populace-build/tests/test_us_fiscal_refresh_builder.py packages/populace-build/tests/test_us_fiscal_targets.py packages/populace-build/tests/test_us_puf_support.pyuv run python -m json.tool packages/populace-build/src/populace/build/us/fiscal_target_references.json >/dev/nulluv run --package populace-build --extra us pytest packages/populace-build/tests/test_us_fiscal_refresh_builder.py packages/populace-build/tests/test_us_puf_support.py(58 passed)uv run --package populace-build --extra us pytest packages/populace-build/tests/test_us_fiscal_targets.py(50 passed)Local diagnostic build
Built the PUF-support base H5 at
out/puf-support-local-20260619/base/base_populace_us_2024_puf_support.h5and ran a full target-surface 128-epoch calibration with--maximum-microsim-batch-size 25000.Result diagnostics:
out/puf-support-local-20260619/calibrated-128-batched-r2/releases/populace-us-2024-puf-support-local-128-batched-r2-20260619/calibration_diagnostics.json.Metrics:
This is not release-valid yet. Remaining hard gate failures:
The mortgage-interest JCT target is no longer zero-support: it materializes at $33.61B final against a $24.8B target after the
interest_deductionmapping change.Review
Read-only cycle review reported no actionable findings. Residual risk: this branch overlaps active fiscal-refresh PRs (#121, #128, #130), so merge order may require follow-up reconciliation.