Skip to content

Support Vantor XML namespaces #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
klassenjs wants to merge 3 commits into
base: master
Choose a base branch
from
+5 −2
Draft

Support Vantor XML namespaces #23

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
509a1f1
Fix encoding declaration.
Jun 14, 2026
08ff527
Ignore namespaces in Vantor XML metadata.
Jun 14, 2026
82916b7
Make sure XML tag name is valid before building regex.
Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/filter_scene.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# -*- coding: UTF-8 -*-
# -*- coding: utf-8 -*-

# Version 3.1; Erik Husby, Ryan Shellberg; Polar Geospatial Center, University of Minnesota; 2019
# Translated from MATLAB code written by Ian Howat, Ohio State University, 2018
Expand Down Expand Up @@ -1882,7 +1882,10 @@ def readFromXml(xmlFile, xml_paramstrs):
while line != '' and None in values:
for ps in xml_paramstrs_left:
if ps in line:
values[xml_paramstrs.index(ps)] = line.replace("<{}>".format(ps), '').replace("</{}>".format(ps), '')
if not re.match(r"^[A-Za-z0-9-_\.]+$", ps):
raise InvalidArgumentError(f"Error: Illegal XML tag name: {ps}")
regex = "<([^:]*:){0,1}"+ps+">(.*)</([^:]*:){0,1}"+ps+">"

@klassenjs klassenjs Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, this should validate that ps doesn't have anything funky in it that could be interpreted as part of the regex instead of just a literal. In practice, ps is controlled by trusted code so it would be unlikely for it to contain something unexpected.

values[xml_paramstrs.index(ps)] = re.sub(regex, r"\2", line)
xml_paramstrs_left.remove(ps)
break
xmlFile_fp.close()
Expand Down