Conversation
Contributor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
==========================================
- Coverage 95.37% 95.16% -0.21%
==========================================
Files 142 142
Lines 11404 11445 +41
Branches 620 629 +9
==========================================
+ Hits 10876 10892 +16
- Misses 399 428 +29
+ Partials 129 125 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timkpaine
force-pushed
the
tkp/314
branch
3 times, most recently
from
57af9e8 to
eb08b21
Compare
- tokenize: add cycle detection for circular closures, stop MRO walk at PydanticBaseModel, fix docstring stripping for Python 3.14 bytecode - tokenize: handle _abc._abc_data objects in normalize_token fallback (Python 3.14 exposes these in function closures of ABC-derived classes) - arrow: move Literal sentinel values to module level for deferred annotation evaluation - pyproject: pin csp<1 for python<3.14 (no 3.14 wheels yet) - tests: adapt assertions for Python 3.14 behavior changes (enum docs, error messages, argparse/Hydra incompatibility) Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
ptomecek
reviewed
May 27, 2026
| annotate = annotationlib.get_annotate_from_class_namespace(namespaces) | ||
| if annotate is None: | ||
| return {} | ||
| return dict(annotationlib.call_annotate_function(annotate, annotationlib.Format.VALUE)) |
Collaborator
There was a problem hiding this comment.
Why Format.VALUE instead of Format.FORWARDREF, which I think will handle unresolved forward refs better?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.