Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions .github/workflows/e2e-advisory.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,21 +31,24 @@ on:
workflow_dispatch:
push:
branches:
# The branches `build.yml` deploys from — a regression is caught where
# it lands, which is when bisecting is cheapest.
#
# This still cannot block anything: different runner pool, no
# cross-workflow `needs`, and it is not a required status check. The
# job name says "advisory" so a red X next to the build jobs cannot be
# misread. See E2E_USER_STORIES.md.
- develop
- 'release/**'
- 'rc/**'
# For iterating on CI itself. Deliberately outside the `feat/*`,
# `fix/*`, `custom/*`, `refactor/*` set PR Flow watches, so this never
# triggers a build or a `build/<branch>/<app>` deploy.
- 'e2e/**'
#
# STAGE 2 — not yet. Add `develop` (and `release/**`, `rc/**`) once the
# nightly has a track record. Deliberately deferred: `develop` is the
# high-value trigger — it catches a regression where it lands, when
# bisecting is cheapest — but turning it on also puts a new check on
# everyone's commits, and that should be earned rather than assumed.
# Until then `workflow_dispatch` covers any one-off.
#
# It cannot block builds when it is enabled (different runner pool, no
# cross-workflow `needs`, no required status checks on develop) — see
# E2E_USER_STORIES.md. The reason to wait is noise and trust, not risk.
# Still NOT feature branches: there is one self-hosted runner binding
# fixed host ports, so runs serialise. A busy trigger set would build a
# queue that starves the nightly. Use "Run workflow" for a one-off.
schedule:
# 01:10 UTC daily. NB scheduled workflows only run from the DEFAULT branch,
# so the nightly track record does not start accumulating until this file is
Expand Down
11 changes: 5 additions & 6 deletions E2E_USER_STORIES.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,11 @@ check on their commits, and the nightly starts accumulating the record — which
do from the default branch, so this is what breaks the chicken-and-egg of "prove it before
merging it".

**Stage 2 (once the record is good):** add `push: develop`, and `release/**` / `rc/**` to
match the branch set `build.yml` deploys from. `develop` is the high-value trigger — it
catches a regression at the moment it lands, when bisecting is cheapest — and with no
`pull_request` trigger it is also how merges get covered. Deferred because enabling it puts
a new check on everyone's commits, which should be earned rather than assumed. It is a
three-line change.
**Stage 2 (done 2026-08-06):** `push` now covers `develop`, `release/**` and `rc/**` —
the branch set `build.yml` deploys from. `develop` is the high-value trigger: it catches a
regression at the moment it lands, when bisecting is cheapest, and with no `pull_request`
trigger it is also how merges get covered. It still cannot block anything, and the suite had
run green on every invocation up to that point.

**Never:** feature branches. There is one self-hosted runner and the stack binds fixed host
ports, so runs serialise; a busy trigger set would build a queue that delays or starves the
Expand Down