Skip to content

test(events): only count the signals caused by the test #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chillfox merged 1 commit into from
Aug 2, 2026
Merged

test(events): only count the signals caused by the test #385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions spec/controllers/events_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1655,14 +1655,20 @@ describe Events, tags: ["event"] do
WebMock.stub(:post, "#{ENV["PLACE_URI"]}/api/engine/v2/signal?channel=staff/guest/attending")
.to_return(body: "")

system_id = "sys-mirror-echo-test"

# Signals are emitted from spawned fibres, so one belonging to an earlier
# example can still be in flight when this one installs its stub and be
# captured here. This example asserts on exact counts, so it records only
# the signals it caused -- identified by its own dedicated system.
captured_bodies = [] of String
WebMock.stub(:post, "#{ENV["PLACE_URI"]}/api/engine/v2/signal?channel=staff/event/changed")
.to_return do |request|
captured_bodies << (request.body.try(&.gets_to_end) || "")
body = request.body.try(&.gets_to_end) || ""
captured_bodies << body if JSON.parse(body)["system_id"]?.try(&.as_s?) == system_id
HTTP::Client::Response.new(200, body: "")
end

system_id = "sys-mirror-echo-test"
PlaceOS::Model::ControlSystem.find?(system_id).try(&.delete)
test_system = PlaceOS::Model::Generator.control_system
test_system.id = system_id
Expand Down Expand Up @@ -1707,6 +1713,12 @@ describe Events, tags: ["event"] do
first["event_start"].as_i64.should eq thu
first["previous_event_start"].as_i64.should eq wed

# A signal from an earlier example's spawned fibre can still be in flight
# and land here. Stand one in deliberately: the counts below are only
# meaningful if a signal for another system is not mistaken for ours.
HTTP::Client.post("#{ENV["PLACE_URI"]}/api/engine/v2/signal?channel=staff/event/changed",
body: %({"system_id": "sys-unrelated-example", "event_id": "evt-unrelated"}))

# 2) Room copy lags and reports the OLD time (Wed): the stale echo that must
# now be ignored.
client.post("#{EVENTS_BASE}/notify/updated/#{system_id}/#{room_event_id}",
Expand Down
Loading