feat: remove Elasticsearch drop task and constants (PPT-2644) - #104
Merged
Conversation
Search moves to PostgreSQL full-text search; there are no ES indices to drop. `drop` now only drops the PostgreSQL DB. NOTE: ship in the same platform release as the PlaceOS/local change that removes the hard-reset drop:elastic invocation. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of PPT-2644: PlaceOS search now runs on PostgreSQL full-text search. rest-api no longer reads Elasticsearch (in nightly images since 2026-08-12), so there are no ES indices for init to manage.
What
drop:elasticsam task andTasks.drop_elastic_indices;dropnow only runsdrop:db.ES_HOST/ES_PORTconstants fromsrc/constants.cr.drop:elasticrows and updates thedropdescription.Verification
crystal build --no-codegenpasses onsrc/sam.crand all three shard targets (src/start.cr,src/backup.cr,src/restore.cr).grep -riE 'elastic|search[-_]ingest|neuroplastic|reindex|ES_HOST|ES_PORT'oversrc/,spec/, and the README returns nothing.Merge order
Pairs with PlaceOS/local#145 — its
hard_resetcurrently invokes thedrop:elastictask this PR removes — so ship both in the same release window.