chore: track pipelex keyword-only refactor + migrate to PipelexMTHDSProtocol#55
chore: track pipelex keyword-only refactor + migrate to PipelexMTHDSProtocol#55lchoquel wants to merge 3 commits into
Conversation
…rotocol Pin pipelex to the keyword-only-arguments refactor branch (git rev) and migrate the sample app off the removed PipelexRunner class. - pyproject/uv.lock: pin pipelex to git rev 529b9082 (keyword-only branch) - hello_world.py: PipelexRunner -> PipelexMTHDSProtocol, execute_pipeline() -> execute() make agent-check and agent-test pass; uv lock --locked is consistent. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Greptile SummaryThis PR tracks the in-flight Pipelex runtime API refactor. The main changes are:
Confidence Score: 4/5This is close, but the install path mismatch should be fixed before merging.
Important Files Changed
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
pyproject.toml:55
**Standard installs break** The app now imports `PipelexMTHDSProtocol`, but the project dependency still advertises `pipelex>=0.32.0` and the git pin is only in `[tool.uv.sources]`. Standard installers such as `pip install .` ignore this uv-only section, so the README quick-start path can install the released PyPI package that still lacks `PipelexMTHDSProtocol`, causing `my_project/hello_world.py` to fail at import time.
Reviews (1): Last reviewed commit: "chore: track pipelex keyword-only refact..." | Re-trigger Greptile |
|
|
||
| [tool.uv.sources] | ||
| # Temporary: track the keyword-only-arguments refactor branch of pipelex until it is released to PyPI. | ||
| pipelex = { git = "https://github.com/Pipelex/pipelex.git", rev = "529b908255e0eb513038a2d92a58730185a22b74" } |
There was a problem hiding this comment.
Standard installs break The app now imports
PipelexMTHDSProtocol, but the project dependency still advertises pipelex>=0.32.0 and the git pin is only in [tool.uv.sources]. Standard installers such as pip install . ignore this uv-only section, so the README quick-start path can install the released PyPI package that still lacks PipelexMTHDSProtocol, causing my_project/hello_world.py to fail at import time.
Prompt To Fix With AI
This is a comment left during a code review.
Path: pyproject.toml
Line: 55
Comment:
**Standard installs break** The app now imports `PipelexMTHDSProtocol`, but the project dependency still advertises `pipelex>=0.32.0` and the git pin is only in `[tool.uv.sources]`. Standard installers such as `pip install .` ignore this uv-only section, so the README quick-start path can install the released PyPI package that still lacks `PipelexMTHDSProtocol`, causing `my_project/hello_world.py` to fail at import time.
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7df43bb451
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| [tool.uv.sources] | ||
| # Temporary: track the keyword-only-arguments refactor branch of pipelex until it is released to PyPI. | ||
| pipelex = { git = "https://github.com/Pipelex/pipelex.git", rev = "529b908255e0eb513038a2d92a58730185a22b74" } |
There was a problem hiding this comment.
Keep pip installs on a compatible Pipelex version
This adds only a tool.uv.sources override, which uv's own help describes as outside the standards-compliant publishable metadata, so the package metadata still allows pipelex[mistralai,anthropic,google,google-genai,bedrock,fal]>=0.32.0. Any install path that does not use uv's source override (including the README's documented pip install ., or a resolver constrained to 0.32.x) can install a Pipelex version that lacks the newly imported PipelexMTHDSProtocol, causing my_project.hello_world to fail at import time; please make the runtime dependency itself require the first compatible release/direct ref or remove/update the pip install path while this pin is needed.
Useful? React with 👍 / 👎.
…ngs) Tracks the latest pipelex keyword-only refactor commit, which reorders several function signatures to keyword-only. No call-site changes needed here — every call site already passes the affected args by keyword. agent-check + agent-test green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Bumps the pinned pipelex git rev 755b8211 -> 0e32c8c0. That commit makes all remaining non-subject params keyword-only (no reordering); all call sites here already pass by keyword, so this is a no-op bump. agent-check + agent-test green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
What
Pins this starter template to the pipelex keyword-only-arguments refactor branch (
refactor/Function-calling-4) to validate it in lockstep, and migrates the sample app off the removedPipelexRunnerclass.Changes
pyproject.toml/uv.lock: add a temporary[tool.uv.sources]git pin forpipelexat rev529b9082.my_project/hello_world.py:PipelexRunner→PipelexMTHDSProtocol,execute_pipeline()→execute(). The runner class was renamed upstream when it became the MTHDS Protocol implementation (PipelexRunnerremoved;execute_pipeline→execute).response.pipe_outputis unchanged.CHANGELOG.md:[Unreleased]entry.Why both changes
The pinned PyPI
pipelex(0.32.x) still hadPipelexRunner. Pinning to the branch (which tracks pipelexdev) surfaces the already-landed runtime-runner rename in addition to the keyword-only work, so the sample app needs the rename to keep building.Verification
Local, all green:
make agent-check,make agent-test,uv lock --locked.Note
The git-rev pin is temporary — swap it back to a released
pipelexversion (>=) once the keyword-only refactor lands on PyPI.🤖 Generated with Claude Code