chore(deps): bump pipelex git rev to dee747a#31
Conversation
test: add validation for TOML syntax errors in test_validate_errors.py
Update the pinned pipelex dependency from 318d248 to dee747a in pyproject.toml and uv.lock. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FXE9nEFifcRJhVyvbT6JHh
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b239e8e344
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Greptile SummaryThis PR updates the API boot path and the pinned Pipelex dependency. The main changes are:
Confidence Score: 5/5The changes are narrowly scoped to boot configuration coherence, dependency pinning, and matching tests/docs, with no outstanding code issues identified. The updated boot path is covered by unit tests for orchestrator resolution and validation error threading, and the dependency pin change is reflected consistently in project metadata and lockfile.
What T-Rex did
Reviews (2): Last reviewed commit: "fix(orchestration): fail fast on incoher..." | Re-trigger Greptile |
A process boots under exactly one orchestrator, derived from the deployment-default orchestration_mode. But resolve_orchestration_mode honors a per-request override to a *different* mode when allow_request_orchestration_mode_override is on, so the booted stack and the dispatched arm could disagree: a `direct` default (no async hub claimed at boot) with override on would let a request select a non-direct mode and then fail only at dispatch with AsyncExecutionNotEnabledError. Move the boot-mode derivation into api_config.resolve_boot_orchestrator (symmetric with resolve_orchestration_mode, unit-testable without main's import-time side effects) and add a guard that refuses the incoherent combo at startup via ApiBootConfigError. The mirror case (non-direct default + override on) stays coherent and boots normally. Documents the guard in docs/configuration.md. Addresses Codex review on PR #31. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FXE9nEFifcRJhVyvbT6JHh
Summary
Bump the pinned
pipelexgit dependency rev from318d248todee747ainpyproject.tomlanduv.lock.Test plan
🤖 Generated with Claude Code
https://claude.ai/code/session_01FXE9nEFifcRJhVyvbT6JHh
Summary by cubic
Boot the API under the orchestrator derived from
orchestration_mode, and refuse adirectdefault with per-request override to prevent async dispatch failures. Also bumpspipelextodee747aand updates docs/config.Refactors
resolve_boot_orchestratorand fail fast withApiBootConfigErrorwhenallow_request_orchestration_mode_override=trueon adirectdefault.boot_orchestratortoPipelex.makeso non-direct modes claim the async hub at startup;directboots in-process.docs/configuration.md.feature_configfrom.pipelex/pipelex.toml.mkdocs.yml.resolve_boot_orchestratorand for TOML syntax errors surfacing with the threadedsourceon/v1/validate.Dependencies
pipelexgit rev todee747ainpyproject.tomlanduv.lock.Written for commit 3ff6961. Summary will update on new commits.