Skip to content

chore(deps): bump pipelex git rev to dee747a#31

Merged
lchoquel merged 6 commits into
devfrom
feature/MCP-2
Jun 28, 2026
Merged

chore(deps): bump pipelex git rev to dee747a#31
lchoquel merged 6 commits into
devfrom
feature/MCP-2

Conversation

@lchoquel

@lchoquel lchoquel commented Jun 28, 2026

Copy link
Copy Markdown
Member

Summary

Bump the pinned pipelex git dependency rev from 318d248 to dee747a in pyproject.toml and uv.lock.

Test plan

  • CI passes

🤖 Generated with Claude Code
https://claude.ai/code/session_01FXE9nEFifcRJhVyvbT6JHh


Summary by cubic

Boot the API under the orchestrator derived from orchestration_mode, and refuse a direct default with per-request override to prevent async dispatch failures. Also bumps pipelex to dee747a and updates docs/config.

  • Refactors

    • Add resolve_boot_orchestrator and fail fast with ApiBootConfigError when allow_request_orchestration_mode_override=true on a direct default.
    • Pass boot_orchestrator to Pipelex.make so non-direct modes claim the async hub at startup; direct boots in-process.
    • Document the boot-coherence guard in docs/configuration.md.
    • Remove experimental feature_config from .pipelex/pipelex.toml.
    • Remove MCP docs link from mkdocs.yml.
    • Add unit tests for resolve_boot_orchestrator and for TOML syntax errors surfacing with the threaded source on /v1/validate.
  • Dependencies

    • Bump pipelex git rev to dee747a in pyproject.toml and uv.lock.

Written for commit 3ff6961. Summary will update on new commits.

Review in cubic

lchoquel and others added 5 commits June 24, 2026 19:00
test: add validation for TOML syntax errors in test_validate_errors.py
Update the pinned pipelex dependency from 318d248 to dee747a in
pyproject.toml and uv.lock.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FXE9nEFifcRJhVyvbT6JHh

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b239e8e344

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread api/main.py Outdated
@greptile-apps

greptile-apps Bot commented Jun 28, 2026

Copy link
Copy Markdown

Greptile Summary

This PR updates the API boot path and the pinned Pipelex dependency. The main changes are:

  • Derive the boot orchestrator from API configuration.
  • Reject direct-default request override configs at startup.
  • Pass the boot orchestrator into Pipelex.make.
  • Update Pipelex git pins in pyproject.toml and uv.lock.
  • Add tests and docs for boot coherence and validation source threading.

Confidence Score: 5/5

The changes are narrowly scoped to boot configuration coherence, dependency pinning, and matching tests/docs, with no outstanding code issues identified.

The updated boot path is covered by unit tests for orchestrator resolution and validation error threading, and the dependency pin change is reflected consistently in project metadata and lockfile.

T-Rex T-Rex Logs

What T-Rex did

  • Traced the boot_orchestrator guard across four configs, noting that the before state had no resolve_boot_orchestrator and the after state returns vary by mode: direct returns None, temporal returns 'temporal', and direct+override raises ApiBootConfigError, with lifespan behavior determined by Pipelex.make.
  • Inspected the validation endpoint response cycle, recording that the base head showed STATUS=200 OK, is_valid=false, a TOML syntax error, and no source in the validation error, while the head after the change retained 200 OK and is_valid=false but added source: 'broken.mthds'.
  • Reviewed the code and docs to confirm the pipelex revision path, observing that before the change pyproject.toml/uv.lock showed rev 3a8ffcf96626bdd14f3270b376919e2ad0dddc0f with feature_config_exists and mcp_nav_url_exists, and no boot-coherence guard in docs, while after the change the head shows rev dee747ad0f33e71a0f0c9c453235ec1e1ed5fbf1, feature_config_exists=False, mcp_nav_url_exists=False, and a Boot-coherence guard line added to docs/configuration.md.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (2): Last reviewed commit: "fix(orchestration): fail fast on incoher..." | Re-trigger Greptile

A process boots under exactly one orchestrator, derived from the
deployment-default orchestration_mode. But resolve_orchestration_mode
honors a per-request override to a *different* mode when
allow_request_orchestration_mode_override is on, so the booted stack and
the dispatched arm could disagree: a `direct` default (no async hub
claimed at boot) with override on would let a request select a non-direct
mode and then fail only at dispatch with AsyncExecutionNotEnabledError.

Move the boot-mode derivation into api_config.resolve_boot_orchestrator
(symmetric with resolve_orchestration_mode, unit-testable without main's
import-time side effects) and add a guard that refuses the incoherent
combo at startup via ApiBootConfigError. The mirror case (non-direct
default + override on) stays coherent and boots normally. Documents the
guard in docs/configuration.md.

Addresses Codex review on PR #31.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FXE9nEFifcRJhVyvbT6JHh
@lchoquel lchoquel merged commit 9d0665d into dev Jun 28, 2026
16 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 28, 2026
@lchoquel lchoquel deleted the feature/MCP-2 branch June 28, 2026 18:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant