feat/fix: app metadata, canonical gist_posted event, landing cleanup (#870-873) - #884
Merged
Conversation
Replace the scaffold title/description with GistPin's real metadata, add a favicon (the header logo) and basic OpenGraph tags. Fixes #870 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The event filter loosely accepted both 'post_gist' and 'gist_posted' (and even an empty name). Pin it to the single canonical event name emitted by the contract via a shared GIST_POSTED_EVENT constant, documented against the contract. Fixes #871 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Remove the commented-out Hero/HowItWorks/CTA imports and dead code from page.tsx so it matches what actually renders (Features + Footer), and drop the import + usage of the non-existent grid-pattern component from CTA.tsx so the file is internally consistent. Fixes #872 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
post_gist now publishes a single 'gist_posted' event (topic = event name, data = the full Gist record) so the backend indexer can reconcile on-chain state. Documents the event schema in the contract README and adds a test asserting the event is emitted. Note: compile-checked by inspection only — cargo/soroban toolchain is not available in this environment. Fixes #873 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Frontend polish, a backend/contract event-name reconciliation, and the first
Wave 1 contract change (event emission).
Changes
layout.tsxwith GistPin’s real title/description, a favicon (the headerlogo), and basic OpenGraph tags.
both
post_gistandgist_posted(and an empty name). Pinned it to thesingle canonical
gist_postedname via a sharedGIST_POSTED_EVENTconstant.Hero/HowItWorks/CTAimports and dead code frompage.tsxso it matcheswhat renders (
Features+Footer), and dropped the import + usage of thenon-existent
grid-patterncomponent fromCTA.tsx.gist_postedevent.post_gistnow publishes a singlecanonical
gist_postedevent (topic = event name, data = the fullGistrecord) so the backend indexer can reconcile on-chain state. Documented the
event schema in
contracts/README.mdand added a test asserting emission.Verification
is not available in the authoring environment, so it was not compiled.
gist_posted) by design.Closes #870
Closes #871
Closes #872
Closes #873