chore: remove stray contract files and unused ethers dep (#864-865) - #883
Merged
Conversation
vault.rs, multi.rs, ops.rs and rollback.rs were never declared as modules in lib.rs and reference undefined types (e.g. BatchWalletContract) — they are copy-pasted boilerplate from an unrelated wallet/multisig/governance project and are not part of the compiled crate. Only GistRegistry (lib.rs) is real. Remove the dead files. Fixes #864 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
ethers (EVM library) had zero usages anywhere in Backend/src — leftover from an earlier direction. GistPin targets Stellar/Soroban. Remove it and sync the lockfile. Fixes #865 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup of dead code carried over from earlier directions.
Changes
vault.rs,multi.rs,ops.rs,and
rollback.rsfromcontracts/src/. None were declared as modules inlib.rs, they reference undefined types (e.g.BatchWalletContract), andthey’re copy-pasted boilerplate unrelated to GistPin. Only
GistRegistry(
lib.rs) is the real contract.ethersdependency.ethers(an EVM library) had zerousages anywhere in
Backend/src. Removed it frompackage.jsonand syncedthe lockfile.
Verification
lib.rsorCargo.toml.ethershas no usages inBackend/srcand no longer appears inthe lockfile.
Closes #864
Closes #865