fix: frontend build + backend DTO/migration fixes (#860-863) - #882
Merged
Conversation
framer-motion, gsap, @gsap/react, clsx, tailwind-merge, chart.js and react-chartjs-2 were imported in src but not declared, breaking a clean npm install / next build. Note: chart.js/react-chartjs-2 are only used by charter.jsx/prowler.js, removed in #867 — once that lands these two can be dropped. Fixes #860 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
'components/map/Map' is a bare specifier and tsconfig defines no baseUrl, so it could not resolve. Use the '@/' path alias. Fixes #861 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
authorAddress was declared twice (a duplicate-identifier compile error) and @IsStellarAddress was used without being imported, plus a stray 'author' field. Collapse to a single validated authorAddress, import the decorator, and drop the '?? dto.author' workaround in the service. Fixes #862 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The migration filename contained a mangled non-ASCII ellipsis character, which can break migration runs/tooling on some shells and CI. Rename to 1700000000000-EnablePostGIS.ts (matches the class timestamp and the TypeORM migrations glob). Fixes #863 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Two build blockers surfaced by CI: - create-gist.dto.ts: restore the IsString import (still used by the content field) that was dropped while removing the stray author field. - gists.service.ts: define the missing CacheEntry interface referenced by contentCache (left undefined by an earlier merge), which broke the whole backend compile. nest build now passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundles four fixes assigned under this batch: unblocks the frontend build and
corrects two backend defects.
Changes
framer-motion,gsap,@gsap/react,clsx,tailwind-merge,chart.js, andreact-chartjs-2were imported but undeclared, breaking a clean
npm install/next build.Added them to
package.jsonand synced the lockfile.MapLoader.tsximported the barespecifier
components/map/Map(nobaseUrlin tsconfig); switched to the@/alias.authorAddressinCreateGistDto. The field wasdeclared twice (a duplicate-identifier compile error) and
@IsStellarAddresswas used without being imported, plus a stray
authorfield. Collapsed to asingle validated
authorAddress, imported the decorator, and dropped the?? dto.authorworkaround ingists.service.ts.mangled non-ASCII ellipsis to
1700000000000-EnablePostGIS.ts.Verification
npm install).node_modulesnot installed in the authoring environment, so no
tscrun).next buildalso requires Frontend: resolve half-wired landing page (dead imports + missing grid-pattern) #872 (removes the deadgrid-patternimport inCTA.tsx), which lands in thedemilade18-gitPR.Closes #860
Closes #861
Closes #862
Closes #863