Repository navigation
Give a process room to exit in the tests that time one - #19
Merged
Merged
Conversation
…that times one, and drop a test's Postgres tables in one statement, again after a deadlock with a statement the exited worker left running
Piergiuseppe
force-pushed
the
test/room-for-a-process-to-exit
branch
from
November 15, 2026 09:07
16aaaa3 to
fb0f4d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two tests that have nothing wrong with the code they test fail now and then, and with
ci-passedrequired each failure blocks a merge.test_the_cli_exits_within_its_shutdown_timeout_while_a_job_ignores_cancellationfailed on pull request Add tinyjobs move, and delete in the backend protocol #18 (Python 3.13, Postgres 14): a worker with a 2 s shutdown timeout took 2.27 s to exit on the runner, against a bound of 2.15. The tests that time a worker process gave it 0.1, 0.15, 0.3 or 0.6 s to exit, depending on the test. They now sharePROCESS_EXIT_SECONDS = 0.6, which is still under the 1.25 s of the next phase a regression would add.test_the_cli_exits_within_the_shutdown_timeout_with_outcomes_stuck_on_a_lockfailed about half the time against a local Postgres 17, on main too: the cleanup dropped the test's tables one by one while a statement the exited worker had left running on the server still held one of them, and Postgres reported a deadlock. The cleanup now drops them in one statement and tries again after a deadlock. Six runs in a row pass.Only tests change.
Still open, not in this pull request:
test_one_stop_signal_ends_a_process_whose_thread_writes_to_a_stalled_stdouttimed out three times in about ten full local runs under load and passes alone; not understood yet.