Repository navigation
Probe the SQLite write lock in the interrupt sweep instead of timing the next send - #17
Merged
Conversation
…d of timing the next send, which measured how fast the disk took a commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_an_interrupt_anywhere_in_a_transaction_leaves_nothing_openfailed once on main: after one of its ~3100 interrupts the nextsendtook 3.6 s against a limit of 1 s.A probe on a Linux box caught 7 slow sends in 117 runs. In every one the SQLite thread was inside the
COMMITof that send, at a different interrupt point each time, with the loop and the control thread idle: the test was timing the disk, not a lock left behind.The test now asks SQLite directly, from a connection of its own and without waiting, whether the write lock is free after each interrupt and again after the send. Stricter than the timing, and independent of how fast the disk is.