Repository navigation
docs(swang): pin the byte layout of the loss block before 4A-05 writes it - #189
Merged
Merged
Conversation
…s it Docs-only, one commit, one file, one section. No grammar vocabulary, no writer domain, no diagnostics, no code. §6.1's reference document shows exactly one warning — `tempo_approximated`, inline. The other three variants are named by §2.8 and listed by §6.4, but their outer layout was never shown anywhere, so the slice that has to emit them would have had to guess. That is the same gap that let SWG-4A-03 write a `repeat` across four lines where §6.1 spells it on one, and it is cheaper to close now than to discover from a byte-golden afterwards. Settled in §6.2, beside the empty-body rule it belongs with: - `loss` is multiline when the report is non-clean, omitted entirely when it is clean; - one warning is one physical line; - `track_name_invalid_utf8`, `tempo_approximated`, and `other` are inline payload blocks; `smpte_timing_unsupported` is a bare word with no block. With an illustration exhaustive over all four variants, at §6.1's nesting. Two things stated because they are the ones a writer gets wrong: - warning order is vector order, preserved exactly (§2.7). `LossReport` appends and concatenates, the exact walker compares positionally, and duplicates are duplicates. Nothing sorts, groups by variant, or dedupes; - `other` stays one physical line whatever its message holds. A U+000A in the value is `\n` under §6.5's frozen escape policy, never a real line break — so "one warning, one line" is a property of the grammar rather than a hope about the data. The illustration is deliberately not folded into §6.1. That reference stays a single coherent score: its one `tempo_approximated` belongs to the `tempo 100/7` bar above it, and three unrelated warnings bolted on would make it less readable while adding nothing this block does not already say. Refs SWG-4A-05 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018vdRzztKXy8bA16tEzwgLE
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A preflight for SWG-4A-05. Docs-only, one commit, one file, one section of
exact-score-text.md. No grammar vocabulary, no writer domain, nodiagnostics, no code.
The gap
§6.1's reference document shows exactly one warning —
tempo_approximated,inline. The other three variants are named by §2.8 and listed by §6.4, but
their outer layout appears nowhere, so the slice that has to emit them would
have had to guess.
That is the same gap that let SWG-4A-03 write a
repeatacross four lineswhere §6.1 spells it on one. It cost a review round and a second RED→GREEN
pair to find from a byte-golden. Closing it before the code exists is
cheaper, and keeps the golden evidence of a rule rather than the rule itself.
What is settled
With an illustration exhaustive over all four variants, at §6.1's nesting.
Its
track_index 4294967296is deliberate: the normative example now showsa
u64payload doing something au32could not, which is what SWG-CORE-01closed H3 for.
Two things stated because they are the ones a writer gets wrong:
LossReportappends and concatenates, the exact walker compares positionally, and
duplicates are duplicates. Nothing sorts, groups by variant, or dedupes.
otherstays one physical line whatever its message holds. A U+000A inthe value is
\nunder §6.5's frozen escape policy, never a real linebreak — so "one warning, one line" is a property of the grammar rather than
a hope about the data.
What is not changed
The illustration is not folded into §6.1. That reference stays a single
coherent score: its one
tempo_approximatedbelongs to thetempo 100/7bar above it, and three unrelated warnings bolted on would make it less
readable while adding nothing this block does not already say.
Verified: 16 census witnesses green.
🤖 Generated with Claude Code
https://claude.ai/code/session_018vdRzztKXy8bA16tEzwgLE
Generated by Claude Code