Skip to content

build: record griff-cockpit's thiserror edge in Cargo.lock - #144

Merged
PhysShell merged 1 commit into
mainfrom
claude/cargo-lock-cockpit-thiserror
Jul 19, 2026
Merged

PhysShell merged 1 commit into
mainfrom
claude/cargo-lock-cockpit-thiserror

Conversation

@PhysShell

Copy link
Copy Markdown
Owner

What

A one-line Cargo.lock reconciliation. cockpit/Cargo.toml gained a thiserror
dependency in 3C-A (the curation adapter's typed CurationStoreError), but the
merge never carried the corresponding Cargo.lock edge. CI does not build
--locked, so the drift slipped through — and cargo build --locked on main
would fail.

The change

Exactly one line: thiserror 2.0.18 added to the griff-cockpit dependency
list in Cargo.lock. The package is already locked (griff-core/cli depend on
it), so there are no version updates, no new packages, and no manifest or
production-code changes. Produced by cargo check -p griff-cockpit.

 [[package]]
 name = "griff-cockpit"
 ...
  "serde_json",
+ "thiserror 2.0.18",
  "wasm-bindgen",

Validation

  • cargo check --workspace --locked — clean.
  • cargo test -p griff-cockpit --lib --locked — 153 passed, 0 failed.

Lock-only corrective; 3C-B1 follows once this lands.

🤖 Generated with Claude Code

cockpit/Cargo.toml took a thiserror dependency in 3C-A (the curation adapter's
typed CurationStoreError), but the merge did not carry the Cargo.lock edge — CI
does not build --locked, so the drift went unnoticed and `cargo build --locked`
on main would fail. Reconcile the lock with the manifest.

The change is exactly one line: `thiserror 2.0.18` added to the griff-cockpit
dependency list. No version updates, no manifest or production-code changes;
thiserror 2.0.18 is already in the lock (griff-core/cli use it).

- cargo check --workspace --locked: clean
- cargo test -p griff-cockpit --lib --locked: 153 passed

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NkqJUU6d1sW1RAfvyHrqVM
@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c0b5fc5b-92d8-4c22-bbb1-b7bea3697fd5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/cargo-lock-cockpit-thiserror

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@PhysShell
PhysShell merged commit fcac6b8 into main Jul 19, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant