Skip to content

fix bug in permission helpers #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chaneylc merged 1 commit into from
Feb 13, 2026
Merged

fix bug in permission helpers #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dependencies.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ ext.versions = [
minSdk: 16,
compileSdk: 33,
buildTools: "29.0.3",
publishVersion: "0.9.54",
publishVersion: "0.9.55",
publishVersionCode: 1
]

Expand Down
9 changes: 4 additions & 5 deletions phenolib/src/main/java/org/phenoapps/security/SecureActivityImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,10 @@ open class SecureActivityImpl(private val activity: FragmentActivity): SecureFra
//set the callback if permissions are not already granted
mOnResultCallback = onResult

//check permission that aren't granted which are needed
val needed = permissions.associateBy {
ActivityCompat.checkSelfPermission(activity, it) == PackageManager.PERMISSION_GRANTED
}.filter { !it.key }
.map { it.value }
//check permissions that aren't granted which are needed
val needed = permissions.filter {
ActivityCompat.checkSelfPermission(activity, it) != PackageManager.PERMISSION_GRANTED
}

if (needed.isNotEmpty()) {

Expand Down
9 changes: 4 additions & 5 deletions phenolib/src/main/java/org/phenoapps/security/SecureFragmentImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,10 @@ open class SecureFragmentImpl(private val fragment: Fragment): SecureFragmentInt

fragment.context?.let { ctx ->

//check permission that aren't granted which are needed
val needed = permissions.associateBy {
ActivityCompat.checkSelfPermission(ctx, it) == PackageManager.PERMISSION_GRANTED
}.filter { !it.key }
.map { it.value }
//check permissions that aren't granted which are needed
val needed = permissions.filter {
ActivityCompat.checkSelfPermission(ctx, it) != PackageManager.PERMISSION_GRANTED
}

if (needed.isNotEmpty()) {

Expand Down
Loading