Repository navigation
Feeds: no empty space on a card with only a title; a pushed YouTube video gets its description - #347
Merged
Merged
Conversation
…deo del aviso trae su descripción
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
1. No empty space under a title. A feed card is a section (text + the picture of the account on the right). Discord makes a section as tall as its picture, so when the only text is the title, one line sat on top of an empty space. Now a card whose only text is the title (no description and no
extraline) is a plain text display, without the picture of the account; with a description the card is unchanged.2. A pushed YouTube video gets its description. The entry a push carries has no description (#344 uses those entries to post without waiting for the feed), so those cards had none, which showed the empty space above. The call that already asks whether the videos are live (
videos?part=snippet,liveStreamingDetails) returns the description too, so it is read from there when the feed entry has none: no extra quota.How it was checked
check-feeds: a title alone is plain text and a card with a description is still a section; a video that came from a push (the feed does not show it) is posted with the description of the live call. The wholenpm run checkpasses, also with an empty environment like the CI.Note: a video whose description is only links or hashtags still has no first line to show (the first line that says something is used), so it also gets the compact card.