Repository navigation
Move to Bun 1.4.3, type check with bun check, browser tests in WebKit - #24
Merged
Merged
Conversation
Type checking now runs on Bun's built-in checker instead of tsc: each workspace's typecheck script is `bun check`, and the root uses `bun --check`, because its own "check" script takes `bun check` there. Dependencies updated to their latest versions, including CodeMirror, Playwright 1.64 and happy-dom 21. TypeScript stays at 6.0: bun check does not need it, and typescript-eslint supports TypeScript below 6.1. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HuDVwsdvepoX6MWQPfHHjf
The editors tests mark the demos as already given so a first visit opens
a blank document, but they listed old short names ("crab", …) while the
app remembers demos by file ("art.svg", "demos/crab.svg"). Every test
therefore added all six demos and opened the Workbench, whose backdrop
rect raced the phone drawing test's count of rectangles.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HuDVwsdvepoX6MWQPfHHjf
WebKit is the engine of Safari and of every browser on iOS, so it covers more of the people using these tools than Firefox does. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HuDVwsdvepoX6MWQPfHHjf
PeterHewat
changed the title
WebKit logs the SVG app's interactive-widget viewport key, which only Chromium and Firefox read, as a console error. Safari ignores the key, so the tests ignore that one message. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HuDVwsdvepoX6MWQPfHHjf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Peter · project thread
What changed
Bun 1.4.2 → 1.4.3 (
.bun-version,packageManager,engines, CONTRIBUTING). Type checking runs on Bun's built-in checker instead oftsc: every workspace'stypecheckisbun check, and the root's isbun --check(at the root,bun checkruns the repo's owncheckscript, so the flag form is the type checker there). Same for apps made bynew-app.Dependencies updated to latest: CodeMirror language 6.13.1, view 6.43.14, @lezer/highlight 1.2.5, Playwright 1.64.0, happy-dom 21.0.1, @types/bun 1.4.3, prettier 3.9.10, typescript-eslint 8.71.2, vite 8.3.4, plus lockfile refreshes. TypeScript stays on 6.0:
bun checkno longer needs it, but typescript-eslint still requires TypeScript below 6.1. GitHub Actions pins were already on their latest releases.bun.lockstays at format 1.The browser suite runs in Chromium and WebKit (Desktop Safari) instead of Chromium and Firefox: WebKit is the engine of Safari and every iOS browser. CI, README and CONTRIBUTING follow. WebKit logs the SVG app's
interactive-widgetviewport key (read by Chromium and Firefox, ignored by Safari) as a console error, so the editors tests ignore that one message.Browser test fix: the editors spec marked the SVG demos as given using old short names (
"crab"), but the app remembers them by file ("demos/crab.svg"), so every test opened the Workbench demo and its backdrop rect raced the phone drawing test's rectangle count. It now lists the files.Checked that
bun run typecheckfails on a type error in both the root scripts and an app, and passes clean.Checks
bun run verifypasses (665 tests, build OK);bun auditclean🤖 Generated with Claude Code
https://claude.ai/code/session_01HuDVwsdvepoX6MWQPfHHjf