P0 revert: strip the 156-file payload swept into the #5983 squash (regressed class lowering)#5994
P0 revert: strip the 156-file payload swept into the #5983 squash (regressed class lowering)#5994proggeramlug wants to merge 1 commit into
Conversation
|
Important Review skippedToo many files! This PR contains 153 files, which is 3 over the limit of 150. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (153)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Corrected forensics (the PR body's 'swept-in WIP' framing was wrong about provenance, right about effect): the payload is PR #5874 (Improve Zod compatibility support) — it merged to main, main was then force-rewound to remove it, but this PR's branch had rebased onto main during the in-between window and retained So this revert restores main to the rollback's intended state while keeping #5983's pump-lockstep line. #5874's author: the work stays in history at Process lesson for the merge choreography (mine included): after any pre-merge rebase, check |
proggeramlug
force-pushed
the
fix/revert-5983-swept-payload
branch
from
2af54fa to
afe5bb6
Compare
|
Conflict resolved by rebuilding the branch as an inverse patch of the #5874 payload against current main (instead of the earlier snapshot-restore): the five fleet merges that landed meanwhile are preserved — including #5991 ( |
|
Independently bisected this regression (good This branch is currently CONFLICTING because it's based on Suggest closing this in favor of #6015, or I can force-update this branch to the rebased commit if you'd rather keep the PR number — your call. |
proggeramlug
force-pushed
the
fix/revert-5983-swept-payload
branch
from
afe5bb6 to
808a3a6
Compare
|
Rebuilt against current main (11 more fleet merges had landed, re-conflicting the branch). The inverse-patch approach cleanly preserves all five later fixes that touched payload files: #5991 (extends Promise), #5999 (js_dynamic_mod fmod sign-of-zero — #5874's redundant |
…main (preserves 5 later fixes) The #5983 squash unknowingly re-landed force-rewound PR #5874 (Improve Zod compatibility, 849f297, 161 files incl the constv/direct binaries and a class-lowering change that regresses temporal_subclass_capture_writeback_inner_class: 'class X extends <param>' flips from static New to ClassExprFresh/NewDynamic and the capture writeback is lost). Inverse patch of the #5874 payload applied to CURRENT main via 3-way, so the fleet merges that landed on top are preserved: - #5991 (extends Promise): new.rs/new_helpers.rs taken from the prior working revert (unchanged by the 11 intervening merges); its promise_parent_runtime + emit_promise_subclass_init kept, #5874's map_set_default_super_kind scaffold dropped. - #5999 (js_dynamic_mod fmod sign-of-zero): #5874's redundant dynamic_number_operand insertion removed, #5999's 'a % b' kept. - #6004/#6005/#6007 (exotic-receiver dispatch, proxy get, seal on functions): 3-way removed ONLY #5874's hunks from native_call_method.rs/proxy.rs; the later fixes' additions stay. Verified: temporal 6/6 (was 5/6 on main), 806 unchanged, stdlib links, proxy e2e green, and behavioral probes for #5999 (mod -0), #5991 (promise subclass = 42), #6004/#6007 (exotic dispatch + fn seal) all match node. Both stray binaries deleted. #5874 stays in history at 4500b5d for its author to re-land through review after fixing the extends regression.
proggeramlug
force-pushed
the
fix/revert-5983-swept-payload
branch
from
808a3a6 to
5a74594
Compare
|
Superseded by #6015, which landed the same #5874-payload revert (156 files, both binaries removed, class-lowering restored — and additionally documents the 322 test262 regressions #5874 caused). Main is clean; closing this as redundant. The independent verification here (temporal_subclass 6/6, #5991/#5999/#6004/#6005/#6007 behavior preserved) corroborates #6015's approach. |
1 participant
The #5983 squash (
4500b5de4) was intended as one stdlib feature-list line + release metadata, but landed with 161 files (+8108/−745): unreviewed codegen changes (artifacts/closure/entry/function/helpers/method/new/property_get/this_super_call/…), ~30 newtests/*.sh, and a 5.1MBconstvbinary at the repo root — another workstream's WIP that was never part of the PR's review or CI.The payload regressed class lowering on main:
temporal_subclass_capture_writeback_inner_class(issue_5587 suite) fails —class X extends <param>flips from the staticNewpath toClassExprFresh/NewDynamicand the capture writeback is lost (called: 0). Verified two ways: HIR diff between a v0.5.1238-built compiler (static New, passes) and v0.5.1239 (fresh path, fails); and this revert restoring the suite to 6/6 green.This PR restores every unintended path to its v0.5.1238 (
532853f4a) state and deletesconstv. The intended #5983 change —external-http-client-pumpdropped from stdlibfull— is kept (cargo test -p perry-stdliblinks green). The swept-in work remains in history at4500b5de4for its author to re-land through review.I'm still tracing how the payload entered the PR branch between CI-green and merge; full forensics to follow on the tracking issue. Metadata folded at merge as usual.