PG-2795: Clean up minor upgrade scenarios - #185
Merged
Merged
Conversation
comments only, rendered task lists unchanged. removes the dev_singles_commented knob that only existed to reproduce them.
the two packages are already in the deb list installed right before it with state latest, the second task never changed anything. pg-14 did not have it, the other majors did.
…version every other major decides server-dev-all vs common-dev on upgrade_to_pg_version, pg-14 never set that fact and compared the FROM version instead, so an upgrade landing past 14.17 still installed server-dev-all. drops the upgrade_to_fact and dev_switch_var knobs.
…itch the following apt task runs with update_cache anyway, and the dnf postgresql module was already disabled by install_ppg14 earlier in the same play. no other major had this block.
…ead of stop, sleep 1 minute, start pg-14 only did a start, the other majors stopped, paused a minute and started. one restarted through the diagnostics helper covers both, drops the stop_pause knob.
pg_tde ships with ppg 17+, the RHEL dev package switch went away with 18 (common-dev is in the rpm list). pg-18 installed pg_tde before the server rpms were upgraded, now it follows the pg-17 order. drops the tde and dev_switch_active knobs.
minor-upgrade installs the same deb list as install_ppg, which has server-dev-all for every major, 15/16/psp-16 listed common-dev instead. the tests skip the dev package anyway (test_bvt). drops the dev_pkg_deb knob.
only the psp groups trimmed the minor from the psp repo name. compute pg_version_to_install, upgrade_to_pg_version and to_repo_version the same way everywhere, the psp specific tasks stay flavor gated. drops the flavor branches around the repo commands.
…nobs ppg 18 ships no percona-pg-telemetry package (verified against the 18.1/18.4/18.6 apt and yum repos), which is why pg-18 skipped verify_telemetry_upgrade and left percona-pg-telemetry18 out of the post-switch package lists. express that once as major < 18, drops the telemetry_comment and telemetry_upgrade_verify knobs and the two comment variants. rendered output unchanged for every major.
…rade role they compare pg_version_to_install, a 17.x FROM version here, against 16.2 and 16.9, so they could never fire.
Naeem-Akhter
self-requested a review
September 24, 2026 18:13
Naeem-Akhter
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.