PBS-6 feature: Rework storage layer abstractions to support simultaneous reads and writes (part 3) - #190
Merged
percona-ysorokin merged 1 commit intoSep 23, 2026
Conversation
…ous reads and writes (part 3) https://perconadev.atlassian.net/browse/PBS-6 Implemented the most straightforward locking strategy for 'binsrv::storage_core'. * Added an instance of the 'std::shared_mutex' to the 'binsrv::storage_core' class. * Public const methods are now protected with 'std::shared_lock'. * Public mutable methods are now protected with 'std::unique_lock'. * For public methods that are called from other public methods introduced its 'xxx_unsafe()' version to avoid double locking. * Removed 'noexcept' qualifier from methods that create 'std::unique_lock' / 'std::shared_lock'. * Public const methods that return data that is initialized only once during object construction left without locks. * Some methods that used to return references to internal objects now return by value to achieve thread-safety guarantees.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/PBS-6
Implemented the most straightforward locking strategy for 'binsrv::storage_core'.