Skip to content

Rework storage layer abstractions to support simultaneous reads and writes (part 2) - #189

Merged
percona-ysorokin merged 1 commit into
Percona-Lab:mainfrom
percona-ysorokin:mt_storage_core_refactoring
Sep 22, 2026
Merged

percona-ysorokin merged 1 commit into
Percona-Lab:mainfrom
percona-ysorokin:mt_storage_core_refactoring

Conversation

@percona-ysorokin

Copy link
Copy Markdown
Collaborator

https://perconadev.atlassian.net/browse/PBS-6

This is a pre-requisite commit with mostly refactorings:

  • Extracted "unbuffered" part of the 'binsrv::storage' class (that includes binlog_record_container and basic_storage_backend_ptr) into 'binsrv::storage_core'.
  • 'binsrv::storage' class interface reimplemented with this new 'binsrv::storage_core'..
  • 'binsrv::storage::binlog_encryption_record' class-level struct moved to namespace level 'binsrv::binlog_encryption_record'.
  • 'binsrv::storage::binlog_record' class-level struct moved to namespace level 'binsrv::binlog_record'.

The idea behind this refactoring is to separate methods that need to be protected by a mutex from those that do not.

…rites (part 2)

https://perconadev.atlassian.net/browse/PBS-6

This is a pre-requisite commit with mostly refactorings:
* Extracted "unbuffered" part of the 'binsrv::storage' class (that
  includes binlog_record_container and basic_storage_backend_ptr)
  into 'binsrv::storage_core'.
* 'binsrv::storage' class interface reimplemented with this new
  'binsrv::storage_core'..
* 'binsrv::storage::binlog_encryption_record' class-level struct moved
  to namespace level 'binsrv::binlog_encryption_record'.
* 'binsrv::storage::binlog_record' class-level struct moved  to
  namespace level 'binsrv::binlog_record'.

The idea behind this refactoring is to separate methods that need to
be protected by a mutex from those that do not.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@percona-ysorokin
percona-ysorokin merged commit 7f8cb69 into Percona-Lab:main Sep 22, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants