Repository navigation
Add tview, tui-input and tui-textarea interaction adapters - #2
Closed
PerchAnton wants to merge 1 commit into
Closed
PerchAnton wants to merge 1 commit into
PerchAnton wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #9 after renaming the branch to
interaction-check/terminal-input-adapters. The commits and scope are unchanged; please continue review there.Adds external adapters for tview InputField, tui-input and tui-textarea, each with immutable upstream/fix pins and documented boundaries. This branch builds on #1 and targets its branch so the first adapter batch stays separate.
Validation: 9 new scenarios / 45 steps pass locally: tview 15, tui-input 16, tui-textarea 14. Go protocol tests/race/vet, strict Rust adapter Clippy and all 34 runner tests pass. CI extends the matrix to tview on Linux/Windows and two additional Rust widget jobs.
The tui-textarea traces all fail on upstream 4d18622 and pass with the proposed fix in rhysd/tui-textarea#126. Its Cargo dependency deliberately pins our fix branch commit 1a0276461f31a57a74187d22f9d6513a9c539c37; this is not a claim of upstream adoption. No widget code is reimplemented in the adapters; expected states stay in the Python runner.
All 14 jobs pass in both pull-request CI and push CI. Optional consumer proposals are open in tview #1179 and tui-input #50; upstream adoption remains pending.