Add Config for Database Persistence - #9
Conversation
(The current non-helm cache also has database persistence)
matyasselmeci
left a comment
matyasselmeci
left a comment
There was a problem hiding this comment.
LGTM. Can you bump the version in Chart.yaml? This is a new feature, not a bugfix, so let's call it 0.3.0.
(Copied from logging ones)
(I think we want this for the same reasons we're specifying the default LogLocation)
Due to new "database persistence" feature
The first one is a validation check that if you enable database persistence on a separate volume, you either specify a PVC name it can use, or the storageClass so it can make one. Applying the chart fails if the validation fails. The second one is probably not going to be very visible to us but NOTES.txt is a file that gets printed to the console if the user runs |
| Server.TlsCertificate: "/etc/pelican/cert-orig/tls.crt" | ||
| Server.TlsKey: "/etc/pelican/cert-orig/tls.key" | ||
| Server.Hostname: {{ required "serverHostname is required" .Values.serverHostname | quote }} | ||
| Server.DbLocation: "/cache/pelican/pelican.sqlite" |
There was a problem hiding this comment.
Shouldn't this be something like /var/lib/pelican/pelican.sqlite since you're mounting the database volume there?
There was a problem hiding this comment.
Yes, I think I got confused with the non-seperate case. Fixed in d5242fa
2 participants
Basically a copy of what we do for logging (minus the logrotate stuff).
Updated the ci config and the README to include the new knobs